[meta-virtualization] [m-c-s][PATCH 09/11] python-oslo.serialization: add pbr to DEPEND

[Mark Asselstine]

On August 5, 2015 21:14:36 Bruce Ashfield wrote:
> On Wed, Aug 5, 2015 at 4:29 PM, Mark Asselstine
> 
> <mark.asselstine at windriver.com> wrote:
> > Per the package's setup.py we need to depend on python-pbr. Failing to
> > 
> > do so results in a build failure:
> >     Could not find suitable distribution for Requirement.parse('pbr')
> 
> My same comment applies. You'll find 15 or 20 packages that depend on
> pbr, but that didn't specify it.
> 
> We used to get errors if it was specified, since pbr was also coming from
> the base python package.

Were we not pushing our luck a little bit by not addressing the QA errors? By 
luck I mean that without anti-DEPENDS we simply relied on the fact that 
nothing else was causing pbr to be present in the sysroot before these 
packages were built (far from a guarantee).

> 
> Sounds like this is no longer the case.

I believe this is the case but will look to backup this statement with further 
testing today. My current view is:

- Previously => some pkgs _could_ build without pbr DEPENDS
             => building with pbr will/could cause QA issues

- Currently => some pkgs _will_ fail to build without pbr DEPENDS
            => building with pbr does cause QA issues

Since the previous approach was somewhat 'lucky' as described previously I 
would say that this shift in being able to build with pbr and not have QA 
issues is a shift in our favor.

I will follow up with some further test findings.

Mark
      

> 
> Bruce
> 
> > Signed-off-by: Mark Asselstine <mark.asselstine at windriver.com>
> > ---
> > 
> >  meta-openstack/recipes-devtools/python/python-oslo.serialization_git.bb |
> >  1 + 1 file changed, 1 insertion(+)
> > 
> > diff --git
> > a/meta-openstack/recipes-devtools/python/python-oslo.serialization_git.bb
> > b/meta-openstack/recipes-devtools/python/python-oslo.serialization_git.bb
> > index 451c6b9..7f0fb9c 100644
> > ---
> > a/meta-openstack/recipes-devtools/python/python-oslo.serialization_git.bb
> > +++
> > b/meta-openstack/recipes-devtools/python/python-oslo.serialization_git.bb
> > @@ -19,6 +19,7 @@ inherit setuptools
> > 
> >  DEPENDS += " \
> >  
> >          python-pip \
> > 
> > +        python-pbr \
> > 
> >          "
> >  
> >  # RDEPENDS_default:
> > --
> > 2.1.4
> > 
> > --
> > _______________________________________________
> > meta-virtualization mailing list
> > meta-virtualization at yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-virtualization
> 
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end"