[meta-virtualization] [PATCH 2/2] qemu: Enabled VGA output

[Bruce Ashfield]

On Tue, Jan 29, 2013 at 9:11 AM, David Nyström <david.c.nystrom at gmail.com>wrote:

> On Tue 29 Jan 2013 02:54:49 PM CET, Bruce Ashfield wrote:
>
>> On Tue, Jan 29, 2013 at 8:38 AM, David Nyström <david.c.nystrom at gmail.com
>> >**wrote:
>>
>>  On 01/29/2013 02:01 PM, Mihai Prica wrote:
>>>
>>>  Signed-off-by: Mihai Prica <mihai.prica at intel.com>
>>>> ---
>>>>    recipes-devtools/qemu/qemu_1.****3.0.bbappend |    3 +++
>>>>
>>>>    1 file changed, 3 insertions(+)
>>>>    create mode 100644 recipes-devtools/qemu/qemu_1.****3.0.bbappend
>>>>
>>>> diff --git a/recipes-devtools/qemu/qemu_****1.3.0.bbappend
>>>> b/recipes-devtools/qemu/qemu_****1.3.0.bbappend
>>>>
>>>> new file mode 100644
>>>> index 0000000..2106825
>>>> --- /dev/null
>>>> +++ b/recipes-devtools/qemu/qemu_****1.3.0.bbappend
>>>>
>>>> @@ -0,0 +1,3 @@
>>>> +# Enables QEMU to display the VGA output
>>>> +DEPENDS_append = " libsdl"
>>>> +SDL = "--enable-sdl"
>>>>
>>>>
>>>>  Should this really be in meta-virt, this seems a bit distro specific ?
>>>
>>>
>> Can PACKAGECONFIG or a DISTRO_FEATURES help here ? SDL for qemu is
>> probably a bad example, but keeping everything that we think is important
>> for
>> out of box experience, or proper operation, contained within a layer is a
>> good
>> thing .. but leaving it conditional on a distro setting for those that
>> really don't
>> want it, seems to strike the right balance.
>>
>> Cheers,
>>
>> Bruce
>>
>
> Agree, but even in this case, this is something for oe-core to facilitate
> in the qemu recipe.
> Don't get me wrong, I'm not militant about anything, but I would rather
> like to avoid bbappends when possible,
> if oe-core won't accept a PACKAGECONFIG enabling sdl, then lets the merge
> it here.
>

Agreed, one less bbappend is a good thing, and we have a good fallback
position.

Bruce


>
> Br,
> David
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/meta-virtualization/attachments/20130129/4af14bd7/attachment.html>