[meta-virtualization] [PATCH v2 1/2] linux-yocto: added kernel configuration for KVM

[Bruce Ashfield]

On Fri, Jan 25, 2013 at 10:48 AM, Prica, Mihai <mihai.prica at intel.com>wrote:

>
>
> > From: Bruce Ashfield [mailto:bruce.ashfield at gmail.com]
> > Sent: Sunday, January 13, 2013 4:49 PM
> > To: lei yang
> > Cc: Prica, Mihai; meta-virtualization at yoctoproject.org
> > Subject: Re: [meta-virtualization] [PATCH v2 1/2] linux-yocto: added
> kernel configuration for KVM
> >
> >
> >
> > On Sat, Jan 12, 2013 at 1:08 AM, lei yang <yanglei.fage at gmail.com>
> wrote:
> > On Fri, Jan 11, 2013 at 1:08 PM, Bruce Ashfield
> > <bruce.ashfield at gmail.com> wrote:
> > > On Fri, Jan 11, 2013 at 11:27 AM, Mihai Prica <mihai.prica at intel.com>
> wrote:
> > >>
> >> Signed-off-by: Mihai Prica <mihai.prica at intel.com>
> >> ---
> >>  recipes-kernel/linux/linux-yocto_3.4.bbappend |    5 +++++
> >>  1 file changed, 5 insertions(+)
> >>
> >> diff --git a/recipes-kernel/linux/linux-yocto_3.4.bbappend
> >> b/recipes-kernel/linux/linux-yocto_3.4.bbappend
> >> index 5b163ff..6fa02e8 100644
> >> --- a/recipes-kernel/linux/linux-yocto_3.4.bbappend
> >> +++ b/recipes-kernel/linux/linux-yocto_3.4.bbappend
> >> @@ -6,3 +6,8 @@ SRC_URI += "file://xt-checksum.scc \
> >>             file://lxc.scc \
> >>             "
> >>
> >> +KERNEL_FEATURES_append = " kvm/qemu-kvm-enable"
> >
> >
> > Have you confirmed that this is adding the option you want ? I would have
> > expected this to be:
> >
> > KERNEL_FEATURES_append = " features/kvm/qemu-kvm-enable.scc"
> >
> >
> > Hi Bruce,
> >
> > I also notice this, I did a serch in internal layer just found below
> > in wr-kernel use the same way
> >
> > templates/feature/libhugetlbfs/template.conf:KERNEL_FEATURES_append +=
> > "features/hugetlb"
> >
> > I don't know if there is defect for this, both work or not,or we like
> >.scc is there(coding style)
> >
> > They style is an older way of doing things. I have a yocto 1.4 bugzilla
> entry to convert
> > all cases of features that do not end with ".scc" to the more explicit
> format that includes
> > the extension.
> >
> > So no need to do anything special, but just keep in mind to use ".scc"
> when possible,
> > and eventually existing features will be converted.
> >
> > Cheers,
> >
> > Bruce
>
> I see that this hasn't been merged to master. Do I have to redo this  with
> "features/kvm/qemu-kvm-enable.scc" ?
>
>
Hmm. Sorry for letting this sit idle. Yes, let's make that change and I'll
do the
merge. I've recently converted all includes to be explicit, so having this
in the
same format is important.

Cheers,

Bruce


> Mihai
>
> > I'm glad to do a test later.
> >
> > Lei
> >
> >
> >>
> >> +
> >> +module_autoload_kvm = "kvm"
> >> +module_autoload_kvm-amd = "kvm-amd"
> >> +module_autoload_kvm-intel = "kvm-intel"
> >
> >
> > This part looks fine though.
> >
> > Cheers,
> >
> > Bruce
> >
> >>
> >> --
> >> 1.7.9.5
> >>
> >> _______________________________________________
> >> meta-virtualization mailing list
> >> meta-virtualization at yoctoproject.org
> >> https://lists.yoctoproject.org/listinfo/meta-virtualization
> >
> >
> >
> >
> > --
> > "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at
> > its end"
> >
> > _______________________________________________
> > meta-virtualization mailing list
> > meta-virtualization at yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-virtualization
> >
>
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end"
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/meta-virtualization/attachments/20130125/4bebee74/attachment.html>