[meta-virtualization] [RFC] xen: Break volatiles out into separate package.

[Bruce Ashfield]

On Mon, Dec 9, 2013 at 10:17 PM, Chris Patterson <cjp256 at gmail.com> wrote:
> I applied the patch and had a couple notes:
>
> - rename pkg_postinst_${PN}-base -> pkg_postinst_${PN}-volatiles.  As it
> stands, 'populate-volatile.sh update' supposedly only executes when one
> installs xen-base, but it is only there for handling the volatiles.  In my
> testing, I don't think this step is required (it doesn't look like it is
> generating the volatile.cache in the rootfs as I expected) - but it is the
> common practice from what I've seen.

I'd agree with this tweak, since it is simple enough to do as part of the merge.

Phillip: What do you think ? If you want to do a quick repin, I'll wait. If you
don't have the cycles, but agree, I can make the change as part of the merge.

>
> - volatiles indirectly rdepends xen-volatiles now via the script packages. I
> don't see a problem with this as the job is still getting done - but I
> wouldn't mind better defining and cleaning up xen-base a bit (or perhaps
> outright removing it and moving the bits into the appropriate places).

Also agreed. We can put this on a TODO list.

Bruce

>
> Either way, I'm ok with merging. :)
>
> Cheers,
> -Chris
>
>
> On Mon, Dec 9, 2013 at 12:01 PM, Bruce Ashfield <bruce.ashfield at gmail.com>
> wrote:
>>
>> On Thu, Dec 5, 2013 at 5:20 PM, Chris Patterson <cjp256 at gmail.com> wrote:
>> > Looks good to me.
>> >
>>
>> So to confirm for everyone, no objections if this merges as-is ?
>>
>> Bruce
>>
>> >
>> > On Thu, Dec 5, 2013 at 7:09 PM, Bruce Ashfield
>> > <bruce.ashfield at gmail.com>
>> > wrote:
>> >>
>> >> On Tue, Dec 3, 2013 at 9:20 PM, Philip Tricca <flihp at twobit.us> wrote:
>> >> > The Xen scripts for handling block and vif udev events depend on
>> >> > directories created by the Xen volatile directories. In a situation
>> >> > where the 'base' Xen package isn't installed (NDVM etc) these
>> >> > scripts fail silently. The most simple approach I could come up
>> >> > with is just breaking the Xen volatiles config out into it's own
>> >> > package and setting up the logical dependencies.
>> >> >
>> >> > Creating a new package for just a single file seems like overkill
>> >> > to me but it's the most straightforward thing I could come up with.
>> >>
>> >> This seems reasonable to me, there are plenty of other one file package
>> >> examples (in particular since the update-rc.d only works for one
>> >> initscript
>> >> per package), so that isn't all that out of the ordinary.
>> >>
>> >> So to my eye, this looks ok.
>> >>
>> >> Bruce
>> >>
>> >> >
>> >> > Regards,
>> >> > Philip
>> >> >
>> >> > Signed-off-by: Philip Tricca <flihp at twobit.us>
>> >> > ---
>> >> >  recipes-extended/xen/xen.inc |    8 +++++++-
>> >> >  1 file changed, 7 insertions(+), 1 deletion(-)
>> >> >
>> >> > diff --git a/recipes-extended/xen/xen.inc
>> >> > b/recipes-extended/xen/xen.inc
>> >> > index 9d43814..e31e996 100644
>> >> > --- a/recipes-extended/xen/xen.inc
>> >> > +++ b/recipes-extended/xen/xen.inc
>> >> > @@ -53,12 +53,14 @@ RDEPENDS_${PN}-base = "\
>> >> >  RDEPENDS_${PN}-scripts-block = "\
>> >> >      ${PN}-scripts-common \
>> >> >      ${PN}-udev \
>> >> > +    ${PN}-volatiles \
>> >> >      "
>> >> >
>> >> >  RDEPENDS_${PN}-scripts-network = "\
>> >> >      bridge-utils \
>> >> >      ${PN}-scripts-common \
>> >> >      ${PN}-udev \
>> >> > +    ${PN}-volatiles \
>> >> >      "
>> >> >
>> >> >  PACKAGES = "\
>> >> > @@ -106,6 +108,7 @@ PACKAGES = "\
>> >> >      ${PN}-scripts-network \
>> >> >      ${PN}-staticdev \
>> >> >      ${PN}-udev \
>> >> > +    ${PN}-volatiles \
>> >> >      ${PN}-xcutils \
>> >> >      ${PN}-xencommons \
>> >> >      ${PN}-xend \
>> >> > @@ -210,7 +213,6 @@ FILES_${PN}-hypervisor = "\
>> >> >      "
>> >> >
>> >> >  FILES_${PN}-base = "\
>> >> > -    ${sysconfdir}/default/volatiles/99_xen \
>> >> >      ${sysconfdir}/default/xencommons \
>> >> >      ${sysconfdir}/default/xendomains \
>> >> >      ${sysconfdir}/xen/auto \
>> >> > @@ -425,6 +427,10 @@ FILES_${PN}-udev = "\
>> >> >      ${sysconfdir}/udev/rules.d/xend.rules \
>> >> >      "
>> >> >
>> >> > +FILES_${PN}-volatiles = "\
>> >> > +    ${sysconfdir}/default/volatiles/99_xen \
>> >> > +    "
>> >> > +
>> >> >  FILES_${PN}-xcutils = "\
>> >> >      ${libdir}/xen/bin/lsevtchn \
>> >> >      ${libdir}/xen/bin/readnotes \
>> >> > --
>> >> > 1.7.10.4
>> >> >
>> >> > _______________________________________________
>> >> > meta-virtualization mailing list
>> >> > meta-virtualization at yoctoproject.org
>> >> > https://lists.yoctoproject.org/listinfo/meta-virtualization
>> >>
>> >>
>> >>
>> >> --
>> >> "Thou shalt not follow the NULL pointer, for chaos and madness await
>> >> thee at its end"
>> >> _______________________________________________
>> >> meta-virtualization mailing list
>> >> meta-virtualization at yoctoproject.org
>> >> https://lists.yoctoproject.org/listinfo/meta-virtualization
>> >
>> >
>>
>>
>>
>> --
>> "Thou shalt not follow the NULL pointer, for chaos and madness await
>> thee at its end"
>
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"