[meta-virtualization] [PATCH] libvirt: add dtrace pkgconfig option
Bruce Ashfield
bruce.ashfield at windriver.com
Fri Apr 5 08:26:20 PDT 2013
If the host machine has dtrace, or systemtap development libraries
installed, libvirt will detect their headers and enable dtrace probe
support.
But since we don't have a dependency on dtrace, the build will fail
with:
| compilation terminated.
| In file included from ./internal.h:297:0,
| from util/bitmap.h:27,
| from util/bitmap.c:33:
| ./libvirt_probes.h:9:21: fatal error: sys/sdt.h: No such file or directory
There are three problems:
- a host contamination issue
- dtrace/probes being automatically enabled
- a lack of integrated systemtap/dtrace solution
Fixing any of the above will make the problem go away, to fix currently
broken builds, we can fix the problem by adding dtrace as a PACKAGECONFIG
option, and leaving it disabled. This change doesn't add a dtrace/systemtap
dependency to the config entry, since they haven't been confirmed at this
point.
In the future, we should either fix the host contamination or do a full
systemtap/dtrae integration, but for now, simply disabling it is the
best choice.
Signed-off-by: Bruce Ashfield <bruce.ashfield at windriver.com>
---
Sending this patch out for comment, it's minor change. If there are no objections,
I'll push it into the repository tomorrow.
Cheers,
Bruce
recipes-extended/libvirt/libvirt_1.0.3.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/recipes-extended/libvirt/libvirt_1.0.3.bb b/recipes-extended/libvirt/libvirt_1.0.3.bb
index 372e874..bf8c9ec 100644
--- a/recipes-extended/libvirt/libvirt_1.0.3.bb
+++ b/recipes-extended/libvirt/libvirt_1.0.3.bb
@@ -128,6 +128,7 @@ PACKAGECONFIG[remote] = "--with-remote,--without-remote"
PACKAGECONFIG[macvtap] = "--with-macvtap=yes,--with-macvtap=no,libnl,libnl"
PACKAGECONFIG[libvirtd] = "--with-libvirtd,--without-libvirtd"
PACKAGECONFIG[netcf] = "--with-netcf,--without-netcf,netcf,netcf"
+PACKAGECONFIG[dtrace] = "--with-dtrace,--without-dtrace,,"
# Enable the Python tool support
require libvirt-python.inc
--
1.7.10.4
More information about the meta-virtualization
mailing list