[meta-ti] [thud/master][RFC PATCH 2/3] ti-sgx-ddk-um: Add expat as runtime dependency
Denys Dmytriyenko
denys at ti.com
Wed Jul 24 12:24:29 PDT 2019
On Fri, Jul 19, 2019 at 05:06:18PM -0400, Andrew F. Davis wrote:
> Although not needed for the IMG default EGL implementation libexpat
> is needed when using the Mesa EGL version.
Yes, and Rogue has it in RDEPENDS, as it uses Mesa. Why would SGX need it?
> While here s/libudev/udev as 'libudev' is package shipped as part of the
> eudev project, but we use systemd, so we actually depend on 'udev'.
And systemd also provides libudev. From run-time dependency, we really require
libudev, not udev. As udev is just a daemon and bunch of config files - there
is nothing to run-time depend on in there...
> Move the PACKAGE_ARCH and PR defines to a more natural spot that also
> lines up with the RGX version of recipe for easier diffs.
>
> One thing we could have done is remove the DEPENDS line. We do not have
> any build dependencies as these are pre-made library binaries, but I use
> the package rootfs generated by bitbake to build the binaries locally,
> so leave it for now.
Is this detail really necessary for the commit message?
> Signed-off-by: Andrew F. Davis <afd at ti.com>
> ---
> recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> index 3c0242e2..a1e35b52 100644
> --- a/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> +++ b/recipes-graphics/libgles/ti-sgx-ddk-um_1.17.4948957.bb
> @@ -3,9 +3,10 @@ HOMEPAGE = "https://git.ti.com/graphics/omap5-sgx-ddk-um-linux"
> LICENSE = "TI-TSPA"
> LIC_FILES_CHKSUM = "file://TI-Linux-Graphics-DDK-UM-Manifest.doc;md5=b17390502bc89535c86cfbbae961a2a8"
>
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15|k3"
>
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
> +PR = "r33"
>
> BRANCH = "ti-img-sgx/thud/${PV}"
>
> @@ -22,11 +23,10 @@ INITSCRIPT_PARAMS = "defaults 8"
>
> inherit update-rc.d
>
> -PR = "r33"
> PROVIDES += "virtual/egl virtual/libgles1 virtual/libgles2 virtual/libgbm omap5-sgx-ddk-um-linux"
>
> -DEPENDS += "libdrm udev wayland libffi"
> -RDEPENDS_${PN} += "libdrm libudev wayland libffi libdrm-omap"
> +DEPENDS += "libdrm udev wayland libffi expat"
> +RDEPENDS_${PN} += "libdrm libdrm-omap udev wayland libffi expat"
>
> RPROVIDES_${PN} = "libegl libgles1 libgles2 libgbm omap5-sgx-ddk-um-linux"
> RPROVIDES_${PN}-dev = "libegl-dev libgles1-dev libgles2-dev libgbm-dev omap5-sgx-ddk-um-linux-dev"
> --
> 2.17.1
>
More information about the meta-ti
mailing list