[meta-ti] [rocko/master][PATCH v2 01/30] ti-pdk-bbclass: Checking for doxygen support in the correct manner

[Denys Dmytriyenko]

On Fri, Sep 28, 2018 at 10:22:31AM -0400, Radhakrishnan, Mahesh wrote:
> 
> 
> -----Original Message-----
> From: Dmytriyenko, Denys 
> Sent: Thursday, September 27, 2018 5:37 PM
> To: Radhakrishnan, Mahesh
> Cc: meta-ti at yoctoproject.org
> Subject: Re: [meta-ti] [rocko/master][PATCH v2 01/30] ti-pdk-bbclass: Checking for doxygen support in the correct manner
> 
> On Thu, Sep 27, 2018 at 04:43:00PM -0400, Mahesh Radhakrishnan wrote:
> > Signed-off-by: Mahesh Radhakrishnan <m-radhakrishnan2 at ti.com>
> > ---
> >  classes/ti-pdk.bbclass | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/classes/ti-pdk.bbclass b/classes/ti-pdk.bbclass
> > index 0716074..f59969f 100644
> > --- a/classes/ti-pdk.bbclass
> > +++ b/classes/ti-pdk.bbclass
> > @@ -9,8 +9,8 @@ DEPENDS_append_omap-a15 = " ti-cgt-arm-native"
> >  DEPENDS_remove_ti33x = "ti-cgt6x-native"
> >  DEPENDS_remove_ti43x = "ti-cgt6x-native"
> >  DEPENDS_append_omapl1 = " ti-cgt-arm-native"
> > -DEPENDS_remove_am65xx-evm = "gcc-arm-none-eabi-native ti-cgt6x-native"
> > -DEPENDS_append_am65xx-evm = " ti-cgt-arm-native gcc-linaro-baremetal-aarch64-native"
> > +DEPENDS_remove_k3 = "gcc-arm-none-eabi-native ti-cgt6x-native"
> > +DEPENDS_append_k3 = " ti-cgt-arm-native gcc-linaro-baremetal-aarch64-native"

What about these changes? If you need them, you can send this one patch 
separately, no need to re-send all 30.


> >  S = "${WORKDIR}/git"
> >  B = "${WORKDIR}/build"
> > @@ -72,7 +72,7 @@ PARALLEL_XDC = "--jobs=${BB_NUMBER_THREADS}"
> >  PARALLEL_MAKE = ""
> >  
> >  def get_doxygen_support(d):
> > -    if d.getVar('TI_PDK_DOXYGEN_SUPPORT') == '1':
> > +    if d.getVar('TI_PDK_DOXYGEN_SUPPORT', True) == '1':
> 
> "Checking for doxygen support in the correct manner"
> 
> Why the change?
> 
> I was thinking it was a bug fix when the doxygen support was added, but I'm wrong .
> I see the commit now which explains why this was removed 
> https://git.yoctoproject.org/cgit/cgit.cgi/meta-ti/commit/classes/ti-pdk.bbclass?h=rocko&id=195d3f7b93b605eccab685b408f354d35a60884e 
> Apparently meta-processor-sdk-internal's ti-pdk.bbclass  didn't catch up with this change.
> So, pls ignore this patch.
> 
> >          return ''
> >      return 'DOXYGEN_SUPPORT=no'
> >  
> > -- 
> > 1.9.1
> > 
> > -- 
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti at yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti