[meta-intel] [PATCH v2] ledmon: control hard disk led for RAID arrays

[Mittal, Anuj]

On Mon, 2019-03-25 at 23:08 -0400, Liwei Song wrote:
> Enable LED support for Intel Virtual RAID On CPU.
> 
> Signed-off-by: Liwei Song <liwei.song at windriver.com>
> ---
> v2: - use tag version for bb file name
>     - append CFLAGS CPPFLAGS to EXTRA_OEMAKE
>     - remove unused SYSROOT in do_compile
>     - use install-systemd target to install systemd service
> ---
>  recipes-bsp/ledmon/ledmon_0.90_git.bb | 32
> ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>  create mode 100644 recipes-bsp/ledmon/ledmon_0.90_git.bb
> 
> diff --git a/recipes-bsp/ledmon/ledmon_0.90_git.bb b/recipes-
> bsp/ledmon/ledmon_0.90_git.bb
> new file mode 100644
> index 000000000000..9f75facbc23a
> --- /dev/null
> +++ b/recipes-bsp/ledmon/ledmon_0.90_git.bb
> @@ -0,0 +1,32 @@
> +SUMMARY = "Intel(R) Enclosure LED Utilities"
> +
> +DESCRIPTION = "The utilities are designed primarily to be used on
> storage servers \
> + utilizing MD devices (aka Linux Software RAID) for RAID arrays.\
> +"
> +HOMEPAGE = "https://github.com/intel/ledmon"
> +
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM =
> "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
> +"
> +
> +DEPENDS = " udev sg3-utils"

sg3-utils is in meta-oe so this would fail.

> +
> +# aviod parallel build issue traced at 
> https://github.com/intel/ledmon/issues/26
> +PARALLEL_MAKE = ""
> +
> +SRC_URI = "git://github.com/intel/ledmon;branch=master"
> +SRCREV = "8a5d9526e5666e75625427b85a2586436651e89c"

This isn't the revision that 0.90 tag is pointing to. Either the SRCREV
should be changed or PV should be 0.9+git${SRCPV}?

> +
> +COMPATIBLE_HOST = "(i.86|x86_64).*-linux"
> +
> +S = "${WORKDIR}/git"
> +EXTRA_OEMAKE = "CC='${CC}' LDFLAGS='${LDFLAGS}' CFLAGS='${CFLAGS}'
> CPPFLAGS='${CPPFLAGS}'"
> +
> +do_compile() {
> +        oe_runmake
> +}

This isn't necessary. However, it builds manpages too even when api-
documentation is not enabled. So this should be 'oe_runmake ledmon
ledctl'?

> +
> +do_install() {
> +	oe_runmake install DESTDIR=${D}

This is no longer required.

> +	oe_runmake DESTDIR=${D}  install install-systemd

This recipe should also have 'inherit systemd'.

Thanks,

Anuj