[meta-intel] [PATCH] ledmon: control hard disk led for RAID arrays

[Burton, Ross]

On Fri, 22 Mar 2019 at 02:24, Liwei Song <liwei.song at windriver.com> wrote:
> +PARALLEL_MAKE = ""

Is this really needed? How about at least filing a bug upstream.

> +SRC_URI = "git://github.com/intel/ledmon;branch=master"
> +SRCREV = "8a5d9526e5666e75625427b85a2586436651e89c"

Upstream tags releases, so please set the filename to (for example)
ledmon_0.90.git and then set SRCREV to the sha of that tag.

> +EXTRA_OEMAKE = "CC='${CC}' LDFLAGS='${LDFLAGS}'"

Are these needed, as they're exported.  If we need to pass LDFLAGS
like this, why not CFLAGS?

> +do_compile() {
> +        oe_runmake SYSROOT="${STAGING_DIR_TARGET}"
> +}

ross at blackadder ~/Downloads/Holding/ledmon (master)
$ git grep SYSROOT|wc -l
       0

Why are you passing SYSROOT?

> +do_install() {
> +       oe_runmake install DESTDIR=${D}
> +       cd ${S}/systemd
> +       oe_runmake install DESTDIR=${D}
> +}

There's an install-systemd target so you could just do:

oe_runmake DESTDIR=${D}  install install-systemd

Ross