[meta-intel] [PATCH 3/3] lms: add recipe for lms 1921.0.0.0

[Usyskin, Alexander]

> -----Original Message-----
> From: Burton, Ross [mailto:ross.burton at intel.com]
> Sent: Monday, June 17, 2019 15:22
> To: Usyskin, Alexander <alexander.usyskin at intel.com>
> Cc: meta-intel <meta-intel at yoctoproject.org>; Winkler, Tomas
> <tomas.winkler at intel.com>
> Subject: Re: [meta-intel] [PATCH 3/3] lms: add recipe for lms 1921.0.0.0
> 
> On Mon, 17 Jun 2019 at 13:00, Usyskin, Alexander
> <alexander.usyskin at intel.com> wrote:

> > > > +DEPENDS = "metee ace xerces-c libnl libxml2 glib-2.0
> > > > +glib-2.0-native
> > > connman"
> > >
> > > This build-depends on comman?
> > >
> > Yes, we using connman dbus interface and build script tries to detect connman
> availability.
> 
> Just looked at the source.  I suggest adding an option for the networking
> backend to be used, as OE also has network-manager recipes.
> 
Is there any trick to determine what backend is used in .bb file?
So I can build-depend on the right one for now.
Will try to push option to the next release.

> > > > +FILES_${PN} += "${libdir}/*.so"
> > > > +FILES_SOLIBSDEV = ""
> > > > +INSANE_SKIP_${PN} += "dev-so"
> > >
> > > So lms is shipping loadable modules directly into /usr/lib?  Have
> > > you verified that you're not matching too many files here?  Can you
> > > file a bug upstream to follow the best practise of putting them into
> > > a subdirectory of $libdir instead of directly in $libdir?
> > >
> > All loadable libraries are prefixed "lms", so should be unique.
> > The modules co-location is the limitation of ACE dynamic loading.
> 
> Okay, so how about making the FILES expression ${libdir}/lms*.so to ensure that
> you only catch the modules.  Also if they're being shipped as symlinks to e.g.
> lcms-foo.so.1 then you should probably fix that to install directly to the lms-
> foo.so and that should silence the dev-so warning.
> 
Replaced with FILES_${PN} += "${libdir}/libLms*.so"
I'll fix cmake scripts to drop symlinking in the next version.

> Ross