[meta-intel] [PATCH 3/3] lms: add recipe for lms 1921.0.0.0

[Usyskin, Alexander]

> -----Original Message-----
> From: Burton, Ross [mailto:ross.burton at intel.com]
> Sent: Monday, June 17, 2019 11:48
> To: Usyskin, Alexander <alexander.usyskin at intel.com>
> Cc: meta-intel <meta-intel at yoctoproject.org>; Winkler, Tomas
> <tomas.winkler at intel.com>
> Subject: Re: [meta-intel] [PATCH 3/3] lms: add recipe for lms 1921.0.0.0
> 
> On Mon, 17 Jun 2019 at 08:04, Alexander Usyskin
> <alexander.usyskin at intel.com> wrote:
> > +++ b/recipes-bsp/amt/files/lms_drop_rpath_1921.0.0.0.diff
> > @@ -0,0 +1,15 @@
> > +diff --git a/CMakeLists.txt b/CMakeLists.txt index 979ce1b..9da880e
> > +100644
> > +--- a/CMakeLists.txt
> > ++++ b/CMakeLists.txt
> > +@@ -106,10 +106,6 @@ install (DIRECTORY Docs/Licenses
> > +   FILES_MATCHING PATTERN "LICENSE.*"
> > + )
> > +
> > +-list (APPEND CMAKE_INSTALL_RPATH
> > +"${PROJECT_BINARY_DIR}/UNS/GMS_COMMON")
> > +-list (APPEND CMAKE_INSTALL_RPATH
> > +"${PROJECT_BINARY_DIR}/WsmanClient")
> > +-list (APPEND CMAKE_INSTALL_RPATH
> > +"${PROJECT_BINARY_DIR}/UNS/StatusEventHandler")
> > +-
> > + if (BUILD_TESTS)
> > +   include (gtest.cmake)
> > + endif (BUILD_TESTS)
> 
> This patch doesn't have an explanation, an Upstream-Status, or a Signed-off-by.
> 
Will add

> > +LIC_FILES_CHKSUM =
> "file://${S}/COPYING;md5=2ee41112a44fe7014dce33e26468ba93"
> 
> ${S} is working directory, file://COPYING is idiomatic.
> 
> > +inherit cmake systemd pythonnative
> 
> Does it *really* need python-native?  If it just wants to find a python binary then
> you can tell it to use the host Python:
> 
> EXTRA_OECMAKE += "-DPYTHON_EXECUTABLE=${HOSTTOOLS_DIR}/python2"
> 

> Also if this can't use Python 3, which is preferred, then please file a bug
> upstream to point out that Python 2 is EOL next year.
> 
I'm the upstream ;)
And really we need Python3 at build stage. Added EXTRA_OECMAKE, thanks for a tip.

> > +DEPENDS = "metee ace xerces-c libnl libxml2 glib-2.0 glib-2.0-native
> connman"
> 
> This build-depends on comman?
> 
Yes, we using connman dbus interface and build script tries to detect connman availability.

> > +PREFERRED_VERSION_metee = "2.1.0"
> 
> This does nothing, remove.
> 
> > +REQUIRED_DISTRO_FEATURES= "systemd"
> 
> lms can't work without systemd?
> 
Not really, it has no init.d scripts, so we prefer to require systemd.

> > +FILES_${PN} += "${libdir}/*.so"
> > +FILES_SOLIBSDEV = ""
> > +INSANE_SKIP_${PN} += "dev-so"
> 
> So lms is shipping loadable modules directly into /usr/lib?  Have you verified that
> you're not matching too many files here?  Can you file a bug upstream to follow
> the best practise of putting them into a subdirectory of $libdir instead of directly
> in $libdir?
> 
All loadable libraries are prefixed "lms", so should be unique.
The modules co-location is the limitation of ACE dynamic loading.

> > +S = "${WORKDIR}/lms-${PV}"
> 
> This is the default, remove.
> 
> > +SRC_URI = "https://github.com/intel/lms/archive/v${PV}.tar.gz"
> > +SRC_URI[sha256sum] =
> "6eb4b3160ff31ffbfa7f184427d05399534dbea6a89831f8059d3aa10842f1e3"
> 
> GitHub dynamically generated archive, use either maintainer-uploaded tarballs,
> or the git fetcher.
> 
Thanks for a tip, will move to git fetcher from tag.

> > +SRC_URI_append = " file://lms_drop_rpath_${PV}.diff;patch=1"
> 
> patch=1 is the default, remove.
> 
Ok

> > +EXTRA_OECMAKE = " -DCMAKE_INSTALL_PREFIX=${prefix} \
> 
> The cmake class does this already, remove.
Ok

> 
> Ross