[meta-intel] [PATCH v3] libxcam: Initial recipe for libXCam

[Ankit Navik]

Hi Anuj,
Thank you for your feedback.

On Tue, Jul 16, 2019 at 2:20 PM Mittal, Anuj <anuj.mittal at intel.com> wrote:

> Hi Ankit
>
> On Sat, 2019-07-13 at 15:06 +0530, Ankit Navik wrote:
> > +PACKAGECONFIG[gles] = "--enable-gles,--disable-gles,mesa"
>
> I think the DEPENDS here should be virtual/mesa, and,
>

Agree

>
> > +PACKAGECONFIG[vulkan] = "--enable-vulkan,--disable-vulkan,mesa"
>
> vulkan-loader here. Otherwise configure just silently ignore this
> configuration. Also, when enabled, vulkan module fails to compile
> because the include path is wrong:
>

libxcam demands mesa only if vulkan is enabled.
If --enable-vulkan, need to install Mesa3D library.
Let me disable as of now. since vulkan is not mandatory by default.

>
> diff --git a/modules/vulkan/Makefile.am b/modules/vulkan/Makefile.am
> index 22763f0..56578ec 100644
> --- a/modules/vulkan/Makefile.am
> +++ b/modules/vulkan/Makefile.am
> @@ -5,7 +5,7 @@ XCAM_VK_CXXFLAGS = \
>      $(LIBVULKAN_CFLAGS)           \
>      -I$(top_srcdir)/xcore         \
>      -I$(top_srcdir)/modules       \
> -    -I$(top_builddir)/shaders/spv \
> +    -I$(top_srcdir)/shaders/spv \
>      $(NULL)
>
>  XCAM_VK_LIBS = \
>
> Would you be able to check please?
>
Yes, sure.

Regards,
Ankit
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/meta-intel/attachments/20190717/7e009e08/attachment.html>