[meta-intel] [PATCH v2] mkl-dnn: Initial recipe for Intel Math Kernel Library

[Ankit Navik]

Hi Anuj,

On Wed, Feb 13, 2019 at 8:24 AM Mittal, Anuj <anuj.mittal at intel.com> wrote:

> On Tue, 2019-02-12 at 18:44 +0530, Ankit Navik wrote:
> > > > +LICENSE  = "Apache-2.0"
> > > > +LIC_FILES_CHKSUM =
> > > > "file://LICENSE;md5=afa44a3d001cc203032135324f9636b7"
>
> This is missing some licenses for tests. Can you please add the ones at
> the bottom of this list:
>
> https://github.com/intel/mkl-dnn/blob/master/LICENSE

Incorporated in v3.

>


>
> > > > +SECTION = "lib"
> > > > +
> > > > +inherit pkgconfig cmake
> > > > +
> > > > +S = "${WORKDIR}/git"
> > > > +SRCREV = "08bd90cca77683dd5d1c98068cea8b92ed05784d"
>
> Can we use 0.17.4 version instead of 0.18 since that has not been
> released yet and is still an rc?
>
Roger that.

>
> > > > +SRC_URI = "git://github.com/intel/mkl-dnn.git"
> > > > +
> > > > +EXTRA_OECMAKE += "-DMKLDNN_LIBRARY_TYPE=SHARED"
> > > > +EXTRA_OECMAKE += "-DMKLDNN_THREADING=OMP"
> > >
> > > I meant continue enabling the tests/examples, but create a
> > > subpackage called ${PN}-examples for the example files.
> > >
> >
> > I am checking it. Facing some issue "bad RPATH" for tests and
> > examples.
> > Meanwhile, Is it possible to accept the patch v1.
> > I'll fix and submit another patch to include the tests and examples.
>
> It looks like the tests/examples are not installed even when enabled
> ... So this might also need tweaks in Makefile/do_install for those to
> be installed and packaged.
>
Yes, I tried to add do_install_append but I was facing an issue with  "bad
RPATH"
I will submit v3 as of now and fix test and example in another patch set.

Regards,
Ankit
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/meta-intel/attachments/20190213/1e5476c4/attachment.html>