[meta-intel] [PATCH 1/2] intel-media-driver: dont mark warnings as errors

[Anuj Mittal]

Switch the driver configuration MEDIA_BUILD_FATAL_WARNINGS to OFF so
-Werror is not used. Also patch out the use of
-Werror=implicit-function-declaration to prevent errors when building
with gcc9.

| cc1plus: error: '-Werror=' argument
'-Werror=implicit-function-declaration' is not valid for C++ [-Werror]

Signed-off-by: Anuj Mittal <anuj.mittal at intel.com>
---
 ...it-function-declaration-warnings-as-.patch | 35 +++++++++++++++++++
 .../libva/intel-media-driver_19.2.1.bb        |  7 +++-
 2 files changed, 41 insertions(+), 1 deletion(-)
 create mode 100644 recipes-multimedia/libva/intel-media-driver/0001-dont-mark-implicit-function-declaration-warnings-as-.patch

diff --git a/recipes-multimedia/libva/intel-media-driver/0001-dont-mark-implicit-function-declaration-warnings-as-.patch b/recipes-multimedia/libva/intel-media-driver/0001-dont-mark-implicit-function-declaration-warnings-as-.patch
new file mode 100644
index 00000000..d3a7707b
--- /dev/null
+++ b/recipes-multimedia/libva/intel-media-driver/0001-dont-mark-implicit-function-declaration-warnings-as-.patch
@@ -0,0 +1,35 @@
+From 676b76e16ba6468d95c452eb891e34fcfc498c07 Mon Sep 17 00:00:00 2001
+From: Anuj Mittal <anuj.mittal at intel.com>
+Date: Wed, 21 Aug 2019 08:21:39 +0800
+Subject: [PATCH] dont mark implicit-function-declaration warnings as errors
+
+Otherwise, when building with gcc 9.2:
+
+| cc1plus: error: '-Werror=' argument
+|'-Werror=implicit-function-declaration' is not valid for C++ [-Werror]
+
+Also see:
+https://github.com/intel/media-driver/issues/712
+
+Upstream-Status: Pending
+
+Signed-off-by: Anuj Mittal <anuj.mittal at intel.com>
+---
+ media_driver/cmake/linux/media_compile_flags_linux.cmake | 1 -
+ 1 file changed, 1 deletion(-)
+
+diff --git a/media_driver/cmake/linux/media_compile_flags_linux.cmake b/media_driver/cmake/linux/media_compile_flags_linux.cmake
+index 9253b2d6..d2cdb34e 100755
+--- a/media_driver/cmake/linux/media_compile_flags_linux.cmake
++++ b/media_driver/cmake/linux/media_compile_flags_linux.cmake
+@@ -32,7 +32,6 @@ set(MEDIA_COMPILER_FLAGS_COMMON
+     -Wno-overflow
+     -Wno-parentheses
+     -Wno-delete-incomplete
+-    -Werror=implicit-function-declaration
+     -Werror=address
+     -Werror=format-security
+     -Werror=non-virtual-dtor
+-- 
+2.21.0
+
diff --git a/recipes-multimedia/libva/intel-media-driver_19.2.1.bb b/recipes-multimedia/libva/intel-media-driver_19.2.1.bb
index ee5a7f06..53ade25d 100644
--- a/recipes-multimedia/libva/intel-media-driver_19.2.1.bb
+++ b/recipes-multimedia/libva/intel-media-driver_19.2.1.bb
@@ -20,6 +20,7 @@ REQUIRED_DISTRO_FEATURES = "opengl"
 DEPENDS += "libva gmmlib"
 
 SRC_URI = "git://github.com/intel/media-driver.git;protocol=https;branch=intel-media-19.2 \
+           file://0001-dont-mark-implicit-function-declaration-warnings-as-.patch \
            "
 
 SRCREV = "9b648d81fb43f70c49304011371279713cb13ccc"
@@ -34,7 +35,11 @@ inherit cmake pkgconfig
 MEDIA_DRIVER_ARCH_x86    = "32"
 MEDIA_DRIVER_ARCH_x86-64 = "64"
 
-EXTRA_OECMAKE += "-DMEDIA_RUN_TEST_SUITE=OFF -DARCH=${MEDIA_DRIVER_ARCH}"
+EXTRA_OECMAKE += " \
+                   -DMEDIA_RUN_TEST_SUITE=OFF \
+                   -DARCH=${MEDIA_DRIVER_ARCH} \
+                   -DMEDIA_BUILD_FATAL_WARNINGS=OFF \
+                   "
 
 # See: https://github.com/intel/media-driver/issues/358
 FILES_${PN} += " \
-- 
2.21.0