[meta-intel] [meta-intel-qat][PATCH 1/2] zlib-qat: add zlib-qat shim layer version 0.4.10-001

Wed Aug 29 22:11:56 PDT 2018


> -----Original Message-----
> From: Mittal, Anuj
> Sent: Thursday, August 30, 2018 1:06 PM
> To: Tan, Raymond <raymond.tan at intel.com>; meta-intel at yoctoproject.org
> Subject: Re: [meta-intel] [meta-intel-qat][PATCH 1/2] zlib-qat: add zlib-qat
> shim layer version 0.4.10-001
> 
> On 08/30/2018 01:01 PM, Tan, Raymond wrote:
> > Hi Anuj,
> >
> >> -----Original Message-----
> >> From: Mittal, Anuj
> >> Sent: Tuesday, August 28, 2018 9:25 AM
> >> To: Tan, Raymond <raymond.tan at intel.com>; meta-
> intel at yoctoproject.org
> >> Subject: Re: [meta-intel] [meta-intel-qat][PATCH 1/2] zlib-qat: add
> >> zlib-qat shim layer version 0.4.10-001
> >>
> >> Hi Raymond
> >>
> >> On 08/27/2018 05:42 PM, Tan, Raymond wrote:
> >>> This adds zlib-qat shim layer version 0.4.10-001. This specific
> >>> version will work with QAT 1.7 hardware and uses the CMN
> >> driver(libusdm_drv) provided by QAT17.
> >>>
> >>> Signed-off-by: Tan, Raymond <raymond.tan at intel.com>
> >>> ---
> >>>  ...mem-build-qat_contig_mem-ko-against-yocto.patch |  33 ++++++
> >>> ...4.10-001-zlib-Remove-rpaths-from-makefile.patch |  63 +++++++++++
> >>> ...zlib-qat-add-a-install-target-to-makefile.patch |  45 ++++++++
> >>> ...rrect-the-order-for-static-linking-libude.patch |  31 +++++
> >>>  recipes-extended/zlib-qat/zlib-qat_0.4.10-001.bb   | 126
> >> +++++++++++++++++++++
> >>>  5 files changed, 298 insertions(+)
> >>>  create mode 100644
> >>> recipes-extended/zlib-qat/zlib-qat/zlib-qat-0.4.10-001-qat_contig_me
> >>> m- build-qat_contig_mem-ko-against-yocto.patch
> >>>  create mode 100644
> >>> recipes-extended/zlib-qat/zlib-qat/zlib-qat-0.4.10-001-zlib-Remove-r
> >>> pa ths-from-makefile.patch  create mode 100644
> >>> recipes-extended/zlib-qat/zlib-qat/zlib-qat-0.4.10-001-zlib-qat-add-
> >>> a- install-target-to-makefile.patch  create mode 100644
> >>> recipes-extended/zlib-qat/zlib-qat/zlib-qat-0.4.10-001-zlib-qat-corr
> >>> ec t-the-order-for-static-linking-libude.patch
> >>>  create mode 100644 recipes-extended/zlib-qat/zlib-qat_0.4.10-001.bb
> >>>
> >>> diff --git
> >>> a/recipes-extended/zlib-qat/zlib-qat/zlib-qat-0.4.10-001-qat_contig_
> >>> me m-build-qat_contig_mem-ko-against-yocto.patch
> >>> b/recipes-extended/zlib-qat/zlib-qat/zlib-qat-0.4.10-001-qat_contig_
> >>> me m-build-qat_contig_mem-ko-against-yocto.patch
> >>> new file mode 100644
> >>> index 0000000..490b1b1
> >>> --- /dev/null
> >>> +++ b/recipes-extended/zlib-qat/zlib-qat/zlib-qat-0.4.10-001-qat_con
> >>> +++ ti g_mem-build-qat_contig_mem-ko-against-yocto.patch
> >>> @@ -0,0 +1,33 @@
> >>> +From af90f85993558a630b18df17cbf220750f7732af Mon Sep 17 00:00:00
> >>> +2001
> >>> +From: "Tan, Raymond" <raymond.tan at intel.com>
> >>> +Date: Fri, 10 Aug 2018 15:29:21 +0800
> >>> +Subject: [PATCH 1/4] qat_contig_mem: build qat_contig_mem ko
> >>> +against yocto  kernel src
> >>> +
> >>> +Upstream-Status: Inappropriate [Configuration]
> >>> +
> >>> +This tweaks the kernel source and build path in the makefile to
> >>> +make sure the module is built against the right source.
> >>> +
> >>> +Signed-off-by: Tan, Raymond <raymond.tan at intel.com>
> >>> +---
> >>> + contrib/qat/qat_contig_mem/Makefile | 3 +++
> >>> + 1 file changed, 3 insertions(+)
> >>> +
> >>> +diff --git a/contrib/qat/qat_contig_mem/Makefile
> >>> +b/contrib/qat/qat_contig_mem/Makefile
> >>> +index fdcfefc..519d4f6 100644
> >>> +--- a/contrib/qat/qat_contig_mem/Makefile
> >>> ++++ b/contrib/qat/qat_contig_mem/Makefile
> >>> +@@ -87,6 +87,9 @@ else
> >>> +   obj-m	:= $(MODULENAME).o
> >>> + endif
> >>> +
> >>> ++modules_install:
> >>> ++	$(MAKE) -C $(KDIR) M=$(PWD) modules_install
> >>> ++
> >>> + $(MODULENAME)_test: $(MODULENAME)_test.c
> >>> + 	$(CC) -g -o $(MODULENAME)_test $(MODULENAME)_test.c
> >>> +
> >>
> >>
> >> I don't see this or any other kernel module getting installed, is that
> expected?
> >
> > This is intended for zlib-qat 0.4.10 version, as this will be using usdm_drv
> built by qat17 package.
> > Doesn't build the qat_contig_mem as the version 0.4.7 which is for older
> qat16 on older hardware.
> >
> 
> So this version of zlib-qat isn't installing any kernel module?
Yes. It uses the usdm_drv driver that installed with qat17.
> 
> >> This is what I see in buildhistory:
> >>
> >> packages/intel_corei7_64-poky-linux/zlib-qat: PACKAGES: removed
> >> "kernel- module-qat-mem-4.9.81-intel-pk-standard"
> >> packages/intel_corei7_64-poky-linux/zlib-qat/zlib-qat-app: PKGSIZE
> >> changed from 1615072 to 1309936 (-19%)
> >> packages/intel_corei7_64-poky-linux/zlib-qat/zlib-qat-app: FILELIST:
> >> removed "/usr/bin/qat_mem_test"
> >> packages/intel_corei7_64-poky-linux/zlib-qat/zlib-qat-app: RDEPENDS:
> >> removed "libcrypto (['>= 1.0.2n'])", added "libudev (['>= 3.2.5'])"
> >> packages/intel_corei7_64-poky-linux/zlib-qat/zlib-qat-dbg: PKGSIZE
> >> changed from 6445992 to 7597180 (+18%)
> >> packages/intel_corei7_64-poky-linux/zlib-qat/zlib-qat-dbg:
> RRECOMMENDS:
> >> removed "libcrypto-dbg", added "libudev-dbg"
> >> packages/intel_corei7_64-poky-linux/zlib-qat/zlib-qat-dev:
> RRECOMMENDS:
> >> removed "libcrypto-dev kernel-4.9.81-intel-pk-standard-dev
> >> kernel-module-qat-mem-4.9.81-intel-pk-standard-dev", added "udev-
> dev
> >> libudev-dev"
> >> packages/intel_corei7_64-poky-linux/zlib-qat/zlib-qat: PKGSIZE
> >> changed from 14788 to 16314 (+10%)
> >> packages/intel_corei7_64-poky-linux/zlib-qat/zlib-qat: FILELIST:
> >> removed "/etc/zlib_conf/dh895xcc_qa_dev1.conf
> >> /etc/zlib_conf/dh895xcc_qa_dev0.conf", added
> >> "/etc/zlib_conf/c3xxx_dev0.conf /etc/zlib_conf/c6xx_dev2.conf
> >> /etc/zlib_conf/c6xx_dev0.conf /etc/zlib_conf/c6xx_dev1.conf"
> >> packages/intel_corei7_64-poky-linux/zlib-qat/zlib-qat: RDEPENDS:
> >> removed all items "kernel-module-qat-mem-4.9.81-intel-pk-standard"
> >>
> >> No 4.14 kernel module package added ...
> >>
> >> Also, could you please move the common components in a .inc file in a
> >> separate patch?
> >
> > Will separate them in v2 that I will submit later.
> >
> > Since the 2 versions 0.4.7 and 0.4.10 is for different hardware and
> > qat driver. I'm thinking to change the DEPENDS to specific version qat16 and
> qat17 respectively, instead of virtual/qat.  Thoughts?
> >
> 
> Thanks, sounds good to me. Would probably help reduce the confusion ..
Sure. Will make this change. Right now if the version mismatch by the user in conf, e.g. qat16 + zlib-qat_0.4.10
The error message during bitbake is 
---------
ERROR: Nothing PROVIDES 'qat17' (but /home/rahul/raymond/workingdir/harcuvar_sumo/meta-intel-qat/recipes-extended/zlib-qat/zlib-qat_0.4.10-001.bb DEPENDS on or otherwise requires it)
qat17 was skipped: PREFERRED_PROVIDER_virtual/qat set to qat16, not qat17
ERROR: Required build target 'zlib-qat' has no buildable providers.
Missing or unbuildable dependency chain was: ['zlib-qat', 'qat17']
----------
Is this good enough as a general usage for bitbake user? Or is there any specific error message that 
I should include in bb? 
With that said, I will update the README in the layer to show the correct pairing qat17 + 0.4.10 and qat16 + 0.4.7.
If this is sufficient, I will assume the layer user will know which hardware they are running on and thus the correct conf.