[meta-intel] [PATCH] Include recommended packges for all Intel machines

[Alejandro Hernandez]

On 03/20/2017 05:59 PM, Cal Sullivan wrote:
> Hi Jussi,
>
> On 03/20/2017 06:08 AM, Jussi Laako wrote:
>> Moves common MACHINE_EXTRA_RRECOMMENDS to a common include file and
>> add thermald to MACHINE_EXTRA_RRECOMMENDS.
>>
>> Signed-off-by: Jussi Laako <jussi.laako at linux.intel.com>
>> ---
>>   conf/machine/include/meta-intel.inc | 3 +++
>>   conf/machine/intel-core2-32.conf    | 2 --
>>   conf/machine/intel-corei7-64.conf   | 2 +-
>>   conf/machine/intel-quark.conf       | 2 --
>>   4 files changed, 4 insertions(+), 5 deletions(-)
>>
>> diff --git a/conf/machine/include/meta-intel.inc 
>> b/conf/machine/include/meta-intel.inc
>> index 04bd553..38d856f 100644
>> --- a/conf/machine/include/meta-intel.inc
>> +++ b/conf/machine/include/meta-intel.inc
>> @@ -29,6 +29,9 @@ XSERVER_X86_ASPEED_AST = "xf86-video-ast \
>>   # include the user space intel microcode loading support in the 
>> generated images.
>>   MACHINE_ESSENTIAL_EXTRA_RDEPENDS_append = 
>> "${@bb.utils.contains('MACHINE_FEATURES', 'intel-ucode', ' 
>> intel-microcode', '', d)}"
>>   +# recommended extra packages common to all intel machines
>> +MACHINE_EXTRA_RRECOMMENDS_append = " kernel-modules linux-firmware 
>> thermald"
>> +
> The addition of kernel-modules is going to greatly increase the size 
> of -minimal images for intel-corei7-64 and intel-core2-32, as these 
> configurations build a lot of modules. I think it would be best to 
> leave this one in only intel-quark.
>
I agree with Cal here, it has its pros and cons but thats also why we 
have the minimal image, and nope at this moment I am not sure if we 
could remove them completely from quark, I'd have to check.

> Alejandro,
> Do you happen to know if kernel-modules is necessary for intel-quark? 
> It would be nice to be able to remove that completely.
>
> ---
> Cal
>
>>   # for the early boot time kernel microcode loading support,
>>   # merge the microcode data in the final initrd image.
>>   INITRD_LIVE_prepend = "${@bb.utils.contains('MACHINE_FEATURES', 
>> 'intel-ucode', '${DEPLOY_DIR_IMAGE}/microcode.cpio ', '', d)}"
>> diff --git a/conf/machine/intel-core2-32.conf 
>> b/conf/machine/intel-core2-32.conf
>> index c5cfb9c..c15f72b 100644
>> --- a/conf/machine/intel-core2-32.conf
>> +++ b/conf/machine/intel-core2-32.conf
>> @@ -14,8 +14,6 @@ MACHINE_FEATURES += "intel-ucode"
>>     MACHINE_HWCODECS ?= "va-intel gstreamer1.0-vaapi"
>>   -MACHINE_EXTRA_RRECOMMENDS += "linux-firmware"
>> -
>>   MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "gma500-gfx-check"
>>     XSERVER ?= "${XSERVER_X86_BASE} \
>> diff --git a/conf/machine/intel-corei7-64.conf 
>> b/conf/machine/intel-corei7-64.conf
>> index 43e7c1a..1e5de49 100644
>> --- a/conf/machine/intel-corei7-64.conf
>> +++ b/conf/machine/intel-corei7-64.conf
>> @@ -14,7 +14,7 @@ MACHINE_FEATURES += "intel-ucode"
>>     MACHINE_HWCODECS ?= "va-intel gstreamer1.0-vaapi"
>>   -MACHINE_EXTRA_RRECOMMENDS += "linux-firmware lms8"
>> +MACHINE_EXTRA_RRECOMMENDS += "lms8"
>>     XSERVER ?= "${XSERVER_X86_BASE} \
>>               ${XSERVER_X86_EXT} \
>> diff --git a/conf/machine/intel-quark.conf 
>> b/conf/machine/intel-quark.conf
>> index 6e3bb30..17e8c52 100644
>> --- a/conf/machine/intel-quark.conf
>> +++ b/conf/machine/intel-quark.conf
>> @@ -13,8 +13,6 @@ MACHINE_ESSENTIAL_EXTRA_RDEPENDS = ""
>>   MACHINE_FEATURES = "efi usb"
>>   MACHINE_FEATURES += "intel-ucode"
>>   -MACHINE_EXTRA_RRECOMMENDS += "kernel-modules linux-firmware"
>> -
>>   SERIAL_CONSOLE = "115200 ttyS1"
>>   APPEND += "rootwait console=ttyS1,115200 console=tty0"
>