[meta-intel] [PATCH RFC 1/4] systemd-boot: Add patch to systemd boot stub to fix kernel command line

[Cal Sullivan]

On 06/13/2017 12:27 AM, Patrick Ohly wrote:
> On Tue, 2017-06-13 at 10:07 +0300, Jussi Laako wrote:
>> On 12.06.2017 19:16, Wold, Saul wrote:
>>> Is it possible this would be accepted upstream?  or possibly a way to
>>> make it more acceptable upstream check for an "append" check to know it
>>> append vs replace?
>> I think it may still be good idea to make it "prepend" instead of
>> "append" to allow changing console setting. IIRC, kernel uses the first
>> console specified on the command line...
> Does it always use the first value? For example, for "root=/dev/sda
> root=/dev/sdb", which one will it use?
I'll try this out and get back to you.
I'm leaning towards changing it to prepend for the default case, as the 
console is one of the more likely things to be changed in my opinion.

---
Cal

>
> I agree that prepend makes more sense for console. I'm just worried that
> we might need append for other variables, thanks to inconsistent boot
> parameter handling in the kernel :-/
>
> So perhaps RMC needs to support both for values added by database
> entries.
>
> But that wouldn't help with command line parameters, unless we extend
> the parsing and handling of those. Something like:
>
> bootx64.efi root=/dev/sda -> append (the default)
> bootx64.efi ^console=/dev/tty0 -> prepend console=/dev/tty0 (default changed with ^)
> bootx64.efi $console=/dev/tty0 -> append console=/dev/tty0 (default explicitly chosen with $)
> bootx64.efi ! console=/dev/tty0 root=/dev/sda -> replace boot parameters with those given on the command line
>