[meta-intel] [PATCH] lms: use sh instead of bash in notifyDesktop.sh

California Sullivan california.l.sullivan at intel.com
Wed Aug 23 12:56:10 PDT 2017


A recent update to OE-core revealed the missing runtime dependency:

ERROR: lms8-8.0.0-7-r0 do_package_qa: QA Issue: /usr/bin/notifyDesktop.sh
contained in package lms8 requires /bin/bash, but no providers found in
RDEPENDS_lms8? [file-rdeps]

But it turns out that notifyDesktop doesn't actually require bash:

$ checkbashisms.pl notifyDesktop.sh
could not find any possible bashisms in bash script notifyDesktop.sh

So just change the shebang line to /bin/sh.

Signed-off-by: California Sullivan <california.l.sullivan at intel.com>
CC: mikko.ylinen at linux.intel.com
CC: anand.vastrad at intel.com
---
 .../amt/lms/0004-Intel-AMT-ME-real-time-notification-infra.patch        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/recipes-bsp/amt/lms/0004-Intel-AMT-ME-real-time-notification-infra.patch b/common/recipes-bsp/amt/lms/0004-Intel-AMT-ME-real-time-notification-infra.patch
index 6866705..04f584a 100644
--- a/common/recipes-bsp/amt/lms/0004-Intel-AMT-ME-real-time-notification-infra.patch
+++ b/common/recipes-bsp/amt/lms/0004-Intel-AMT-ME-real-time-notification-infra.patch
@@ -1672,7 +1672,7 @@ index 0000000..06bfd97
 --- /dev/null
 +++ b/src/notifyDesktop.sh
 @@ -0,0 +1,10 @@
-+#!/bin/bash
++#!/bin/sh
 +# get list of current users
 +for x in $(who | sort -u -k1,1 | awk '{print $1}'); do
 +  # send message to anyone on display 0
-- 
2.9.5



More information about the meta-intel mailing list