[meta-intel] [PATCH RFC/RFT] systemd-boot: Add patch to systemd boot stub to fix kernel command line

Cal Sullivan california.l.sullivan at intel.com
Thu Apr 13 17:30:52 PDT 2017



On 04/13/2017 03:29 AM, Patrick Ohly wrote:
> On Wed, 2017-04-12 at 17:35 -0700, California Sullivan wrote:
>> +From 726a1722d30376d2e30561854809edfb05e34047 Mon Sep 17 00:00:00
>> 2001
>> +From: California Sullivan <california.l.sullivan at intel.com>
>> +Date: Wed, 12 Apr 2017 11:10:52 -0700
>> +Subject: [PATCH] boot: efi: stub: append LoadOptions to command line
>> instead
>> + of replace
>> +
>> +Upstream-status: Inappropriate
> Why is this inappropriate for upstream? Developers using the upstream
> code might have exactly the same problems, so perhaps it is better to
> change the upstream default, or at least make it configurable there?
>

Well, this is a fairly significant change in functionality. There may be 
people that the current upstream functionality is correct for, or what 
they want, that I don't know about.

Now, reading some of the horror stories of this variable, its definitely 
not correct for many, but neither would my implementation.

Here is fun read that Mikko linked me: 
https://github.com/rhinstaller/shim/blob/master/shim.c#L2362

---
Cal


More information about the meta-intel mailing list