[meta-intel] [jethro] [PATCHv2 1/2] intel-corei7-64: add machine configurations specific to leafhill bsp

[Chang, Rebecca Swee Fun]

After checking with the developers, runlevel 3 is meant for internal testing purposes.
I will push another version of patchset to fix this. Thank you.

Rebecca

-----Original Message-----
From: Saul Wold [mailto:sgw at linux.intel.com] 
Sent: Friday, September 9, 2016 10:34 PM
To: Chang, Rebecca Swee Fun <rebecca.swee.fun.chang at intel.com>; meta-intel at yoctoproject.org
Cc: Sullivan, California L <california.l.sullivan at intel.com>; Zhang, Jianxun <jianxun.zhang at intel.com>
Subject: Re: [jethro] [PATCHv2 1/2] intel-corei7-64: add machine configurations specific to leafhill bsp

On Fri, 2016-09-09 at 09:39 +0800, Rebecca Chang Swee Fun wrote:
> We would like to enable new BSP for Intel Atom E3900 SoC based 
> platforms.
> This will help us to consolidate BSP into intel-common and we can use 
> KERNEL_FEATURES to select target BSP to compile.
> 
> Leaf Hill uses different serial console port setup. Hence this 
> mechanism are in place to enable new bsp with existing machine 
> configurations file.
> 
> Signed-off-by: Rebecca Chang Swee Fun <rebecca.swee.fun.chang at intel.c
> om>
> ---
>  conf/machine/intel-corei7-64.conf | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/conf/machine/intel-corei7-64.conf b/conf/machine/intel- 
> corei7-64.conf index cc16d62..aac14d1 100644
> --- a/conf/machine/intel-corei7-64.conf
> +++ b/conf/machine/intel-corei7-64.conf
> @@ -30,5 +30,7 @@ XSERVER ?= "${XSERVER_X86_BASE} \
>             "
>  
>  SYSLINUX_OPTS = "serial 0 115200"
> -SERIAL_CONSOLE = "115200 ttyS0"
> -APPEND += "console=ttyS0,115200 console=tty0"
> +SERIAL_CONSOLES = "115200;ttyS2 115200;ttyS0"
> +SERIAL_CONSOLES_CHECK = "ttyS2 ttyS0"
Thanks for looking into this and using this paradigm here, this makes it more flexible to multiple boards and devices.

> +APPEND += "console=ttyS2,115200n8 console=ttyS0,115200 console=tty0"
> +APPEND += "${@bb.utils.contains('KERNEL_FEATURES', 'leafhill', '3
> reboot=efi kmemleak=off i915.enable_ipc=1', '', d)}"
Do you intend to hardcode  runlevel 3 for this device, this is the default runlevel, why is this needed?

Sau!