[meta-intel] [PATCH 1/2] intel-corei7-64: add machine configurations specific to leafhill bsp

[Chang, Rebecca Swee Fun]

Hi everyone,
Please see my reply below:

>>
>> diff --git a/conf/machine/intel-corei7-64.conf b/conf/machine/intel- 
>> corei7-64.conf index cc16d62..7a5b400 100644
>> --- a/conf/machine/intel-corei7-64.conf
>> +++ b/conf/machine/intel-corei7-64.conf
>> @@ -29,6 +29,9 @@ XSERVER ?= "${XSERVER_X86_BASE} \
>>               ${XSERVER_X86_VESA} \
>>              "
>>   
>> -SYSLINUX_OPTS = "serial 0 115200"
>> -SERIAL_CONSOLE = "115200 ttyS0"
>> -APPEND += "console=ttyS0,115200 console=tty0"
>> +SYSLINUX_OPTS = "serial ${@bb.utils.contains('KERNEL_FEATURES',
>> 'leafhill', '2', '0', d)} 115200"
>> +SERIAL_CONSOLE = "115200 ${@bb.utils.contains('KERNEL_FEATURES',
>> 'leafhill', 'ttyS2', 'ttyS0', d)}"
> Can we not use the SERIAL_CONSOLES = "115200,ttyS2 115200,ttyS0"
> variable here instead?

I think doing a switch based on KERNEL_FEATURES doesn't scale well and makes things a lot less readable.

We can also do this:

SERIAL_CONSOLES = "115200,ttyS2 115200,ttyS0"
SERIAL_CONSOLES_CHECK = "ttyS2 ttyS0"

This should stop getty from trying to enable non-existent serial consoles, stopping the annoying "trying to respawn" warning we would get every five minutes otherwise.

[Rebecca] I have tried this out and booting this on both Leaf Hill (Broxton platform) and Cherry Hill (Braswell). Both platforms have different console port enabled and Leaf Hill has no issue to display its console output with this configurations. However, this configuration has failed on Cherry Hill where no console output is seen.

The snippet in intel-corei7-64.conf that I have compiled.
SYSLINUX_OPTS = "serial 0 115200"
SERIAL_CONSOLE = "115200;ttyS2 115200;ttyS0"
SERIAL_CONSOLES_CHECK = "ttyS2 ttyS0"
APPEND += "console=ttyS2,115200n8 console=ttyS0,115200 console=tty0"
APPEND += "${@bb.utils.contains('KERNEL_FEATURES', 'leafhill', '3 reboot=efi kmemleak=off i915.enable_ipc=1', '', d)}"

I have tried to change the console sequence in grub.cfg on Cherry Hill boards by putting console=ttyS0,115200 in front of console=ttyS2,115200n8. This will enabled back the console on Cherry Hill but it will again failed on Leaf Hill. It seems like the sequence that I have put up in APPEND matters and it is platform specific. Please correct me if I'm wrong.

Thank you.

Regards,
Rebecca