[meta-intel] [PATCH 1/2] meta-isg: dpdk: fix v2.0.0 build with kernel 4.1

Mittal, AnujX anujx.mittal at intel.com
Tue Oct 6 13:42:50 PDT 2015


Hi Boon Leong,

Thank you for the review. 

> >+---
> >+ lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c | 1 +
> >+ 1 file changed, 1 insertion(+)
> >+
> >+diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c
> >+b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c
> >+index 2305448..4774adb 100644
> >+--- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c
> >++++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c
> >+@@ -2096,6 +2096,7 @@ STATIC s32 ixgbe_clock_in_i2c_byte(struct
> >+ixgbe_hw *hw, u8 *data)
> >+
> >+ 	DEBUGFUNC("ixgbe_clock_in_i2c_byte");
> >+
> >++	*data = 0;
> >+ 	for (i = 7; i >= 0; i--) {
> >+ 		ixgbe_clock_in_i2c_bit(hw, &bit);
> >+ 		*data |= bit << i;
> >+--
> >+1.9.1
> You mentioned that this patch is back-ported from dpdk upstream.
> I looked up in http://www.dpdk.org/browse/dpdk/log/ and search for commit
> b212cb3d806093399d51a49a6b4205a400cec510 or author "Rahul Kumar
> Gupta",
> http://www.dpdk.org/browse/dpdk/commit/?id=b212cb3d806093399d51a49a6b4
> 205a400cec510
> shows that the commit is bad commit reference.

This one is a mistake. Thanks for pointing it out.

This is just hunk of the commit from here:

http://dpdk.org/browse/dpdk/commit/lib/librte_pmd_ixgbe/ixgbe/ixgbe_phy.c?id=e0ba4e77605ab500518247cb6fab98dd3d87ba97


> Look ok.  This patch is found at
> http://www.dpdk.org/browse/dpdk/commit/?id=b90fcf82e8698c7031321c816d01
> 7a291f3ec914
> 
> On inspecting this patch, I found " kni: fix vhost build with kernel 4.1" @
> http://www.dpdk.org/browse/dpdk/commit/?id=8d8fb8aa5836e719d5fb896693b1
> 6afabd5118b9
> which is related to vhost and dpdk.inc does have PACKAGECONFIG option for
> vhost.
> So, I believe that the above patch will be valuable to be included in v2.0.0 ...
> 

Thanks. Will include this one too.

Thanks,
Anuj


More information about the meta-intel mailing list