[meta-intel] [dizzy][PATCH 1/2] meta-crystalforest: use correct compiler for zlib

Darren Hart dvhart at linux.intel.com
Mon Jul 20 09:48:06 PDT 2015



On 7/15/15 9:54 PM, Anuj Mittal wrote:
> Changed the qat_mem makefile to use $(CC) instead
> of gcc directly. This avoids build errors and makes
> sure that right options are being passed for cross-compile.
>

Hi Anuj,

...

> diff --git a/meta-crystalforest/recipes-extended/zlib-qat/zlib-qat/zlib-qat-qat_mem-use-the-right-compiler.patch b/meta-crystalforest/recipes-extended/zlib-qat/zlib-qat/zlib-qat-qat_mem-use-the-right-compiler.patch
> new file mode 100644
> index 0000000..7b9af29
> --- /dev/null
> +++ b/meta-crystalforest/recipes-extended/zlib-qat/zlib-qat/zlib-qat-qat_mem-use-the-right-compiler.patch
> @@ -0,0 +1,31 @@
> +From 22a4ef23792251c284d9766ab5ee87cbeeef2ec4 Mon Sep 17 00:00:00 2001
> +From: Anuj Mittal <anujx.mittal at intel.com>
> +Date: Thu, 16 Jul 2015 11:05:38 +0800
> +Subject: [PATCH] qat_mem: use the right compiler
> +
> +Upstream-Status: Inappropriate [Configuration]

This is not a configuration change. This is a portability fix to the
project build system. At the very least, this should be submitted for
inclusion to the upstream project and noted here. If they refuse to take
it, we can't do a lot about it, but we have a responsibility to submit
the fix and document that here.

> +
> +Use $(CC) instead of gcc directly. Makes sure that the
> +right options are being passed for cross-compile.
> +
> +Signed-off-by: Anuj Mittal <anujx.mittal at intel.com>
> +---
> + contrib/qat/qat_mem/Makefile |    2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/contrib/qat/qat_mem/Makefile b/contrib/qat/qat_mem/Makefile
> +index 0a521f2..2c7c8dc 100644
> +--- a/contrib/qat/qat_mem/Makefile
> ++++ b/contrib/qat/qat_mem/Makefile
> +@@ -64,7 +64,7 @@ MODULENAME 	:= qat_mem
> + KDIR		:= $(KERNEL_SOURCE_ROOT)
> + PWD		:= $(shell pwd)
> + 
> +-CC		:= gcc -Wall -imacros $(KERNEL_SOURCE_ROOT)/include/generated/autoconf.h
> ++CC		:= $(CC) -Wall -imacros $(KERNEL_SOURCE_ROOT)/include/generated/autoconf.h
> + 
> + ifeq ($(KERNELRELEASE),)
> + all:	$(MODULENAME)_test
> +-- 
> +1.7.9.5
> +
> 

-- 
Darren Hart
Intel Open Source Technology Center


More information about the meta-intel mailing list