[meta-intel] [fido][PATCH v2 2/2] meta-crystalforest: qat makefile patches

[Saul Wold]

On 07/08/2015 03:35 PM, Ong, Boon Leong wrote:
>>> I do think that 2/2 --> 1/2 and 1/2 -> 2/2 in this patch-series to
>>> avoid partially update the patchseries and have build issue.
>>>
>> That would have been one option, but since this was a new recipe and the patches
>> are required to start with I would prefer to see them as one patch, future changes
>> could such as improving or modifying a given patch or part of the recipe should be
>> individual patches as they they are incremental changes to a given patch.
>
> Got it. If you find issue in the DPDK series, I will re-format the patch-series to follow
> the above principles for the first time submission of new recipe. Thanks for guidance
> above.
>

I think I understand what you are trying to do with the dpdk series, I 
started looking at it today and began wondering if it would not have 
been easier to have them collapsed, but I understand that you 
cherry-picked and then updated, and introduced the patches before the 
final recipes.

So, when I saw and understood your intent there, having multiple smaller 
ones is OK.  I honestly reviewed the finished product since that was 
easier than trying to decipher the individual patches though!

Sau!
>>
>>> I would like to hear your commend here so that I don't get "dinged' by
>>> you in future ... =-)
>>>
>> I don't mean to be harsh, just trying to be consistent.
> Nay, you are not harsh, honestly.
> I should have use 'advised' instead of 'dinged' ... =-)
>
> Thanks again.
>
>