[meta-intel] [fido][PATCH 0/3] QAT recipe for Intel Riverforest

[Mittal, AnujX]

Thank you for your comments.

> >Is the intent also of this patch set to allow for an upgrade from Dizzy's QAT16
> >(2.2.x based) -> this version?  Or is there no upgrade path on the device for
> >something already installed?
> 
> Anuj's focus is on this QAT v2.3.0-34 version for RiverForest platform on fido.
> Venkat's work on Crystal Forest and Highland Forest were on dizzy on older QAT version.
> There is no plan for now to upgrade the Highland Forest and Crystal Forest device support
> on Fido due to resource constraints and no strong marketing ask.
> 
> Having said above, it is important to have at least matching filename, structure and reuse
> as much as common ingredient to minimize divergence in meta-data which Saul rightful
> pointed that out below.

I had assumed qat to be a single package because there is a single installer script that can be used to build both qat15 & qat16 mux support for platforms that support both. However, to maintain the consistency between dizzy & Fido, I have changed the recipe name & other metadata to match that of dizzy. Have also changed do_compile to match that from dizzy.

Using the qat installer script minimizes the environment variables that need to be exported from recipe, ensures a bit cleaner do_compile & also avoids PARALLEL_MAKE="" though.

> 
> >
> >If it's intended as an upgrade then renaming from qat16 -> qat will allow for that
> >to happen with out some additional METADATA, such as the PROVIDES_<pkg> /
> >RPROVIDES_<pkg> and RREPLACES_<pkg>.
> >
> >
> >Are you coordinating with venkatasubramanianx.pattu at intel.com, who is working
> >with the Dizzy based patches?  It seems that these should be sharing a similar
> >base.  Maybe work together to review changes the changes.
> Yes, common code base is important.
> 
> >
> >The Dizzy based QAT recipes are using the correct $B and $S correctly, please
> >consider looking at that.
> >
> >I attempted to build your version here and it did not even unpack the
> >QAT1.6/QAT1.6.L.2.3.0-34.tar.gz.

This should have worked, sorry about this. I have changed this to match that from dizzy. Can you please try the new patches?

> >
> >The do_install_prepend should not be doing a blind "cp -Pr ${B}/* ${D}".
> >

Removed usage of ${B} to not to confuse with standard build directory.

The qat makefiles just dump everything to a folder in the compile step itself.. there's no separate install target. I have added patches to ensure that they copy files to correct folders within a single output directory and am copying these files to ${D} in do_install_prepend. 

This has been done to move the copy/install logic in do_install away from the recipe as much as possible & make it more compact & scalable. I think do_install  is the only part that is different from what has been merged in dizzy now. Please let me know if you think this is okay.

Thanks,
Anuj