[meta-intel] [PATCH 12/12] fri2-noemgd: add microcode filter parameter

[Kamble, Nitin A]

On 10/3/14, 7:15 AM, "Zanussi, Tom" <tom.zanussi at intel.com> wrote:

>On Thu, 2014-10-02 at 11:27 -0700, nitin.a.kamble at intel.com wrote:
>> From: Nitin A Kamble <nitin.a.kamble at intel.com>
>> 
>> The fri2-noemgd BSP is targeted to a very specific platform, and it only
>> need microcodes related to a specific processor. So use the microcode
>> filtering mechanism to reduce the unutilized microcode data on the
>>target
>> image.
>> 
>> Signed-off-by: Nitin A Kamble <nitin.a.kamble at intel.com>
>> ---
>>  meta-fri2/conf/machine/fri2-noemgd.conf | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/meta-fri2/conf/machine/fri2-noemgd.conf
>>b/meta-fri2/conf/machine/fri2-noemgd.conf
>> index 345d421..c10ec20 100644
>> --- a/meta-fri2/conf/machine/fri2-noemgd.conf
>> +++ b/meta-fri2/conf/machine/fri2-noemgd.conf
>> @@ -12,6 +12,8 @@ require conf/machine/include/meta-intel.inc
>>  MACHINE_FEATURES += "wifi 3g pcbios efi"
>>  MACHINE_FEATURES += "intel-ucode"
>>  
>> +UCODE_FILTER_SIGNATURES = "-s 0x00020661"
>> +
>
>What does this hex value represent, exactly?  Could you put a comment
>here to explain that, so the next person that comes along has some idea
>what it means.
Yes, a comment should help here.

>
>Also, I'm wondering why the -s is included here - wouldn't it be better
>to hide that from the user and put it in the code that uses it?
More than one signature can be selected here. There are also different
ways of choosing the signatures.

>
>It looks like this variable can be used to specify any iucode tool
>parameter, not just filter signatures.  If so, it needs to have a more
>generic name to reflect that.
It can be changed to UCODE_FILTER_PARAMETERS.

>
>In any case, I think the variable usage needs to be documented in the
>README (I see that it's mentioned, but it doesn't say anything about the
>details of the expected format, etc).  It might make sense to have a
>per-feature subsection for 'related variables' for this purpose, or
>something similar.

Make sense.

Nitin

>
>Tom
>
>
>
>>  MACHINE_EXTRA_RRECOMMENDS += "linux-firmware-iwlwifi-6000g2a-5"
>>  
>>  PREFERRED_PROVIDER_virtual/kernel ?= "linux-yocto"
>
>