[meta-intel] [PATCH 15/21] meta-crystalforest: removed using of intel-common-pkgarch.inc

[Darren Hart]

On 5/8/14, 14:14, "Kamble, Nitin A" <nitin.a.kamble at intel.com> wrote:

>This commit does not make sense. The purpose of pkgarch is to share the
>package architecture of kernel packages across different BSPs. It does
>not inhibit selection of preferred kernel version.
>
>Darren,
>   Do you have any further commit for this approach?

I understand Nitin's comment, ideally we would want all of meta-intel to
use the same SRCREVs for each kernel we build.

You can, as Nitin says, set PREFERRED_PROVIDER_virtual/kernel and
PREFERRED_VERSION_linux-yocto independently from the
intel-common-pkgarch.inc.

However, I don't think Wei Sern was referring to "PREFERRED_PROVIDER" or
"PREFERRED_VERSION" by "preferred kernel version", I suspect he was
referring to SRCREV. ISG validates on a specific kernel version and they
want to release only what they have validated.

In the future, I would like to see us consolidate here. However, it is
their choice which kernel and which SRCREV's they validate against. I
would caution Wei Sern not to avoid using the common pkgarch lightly as it
 adds a lot of overhead to the builder and weakens the Intel advantage
story. However, if they cannot support the SRCREVs we ship with the rest
of the BSPs, this may be the only option.

If that is their position, I wouldn't block this patch.

--
Darren

>
>Thanks,
>Nitin
>
>On 5/7/2014 5:19 PM, wei.sern.chan at intel.com wrote:
>> From: Chan Wei Sern <wei.sern.chan at intel.com>
>>
>> Removed using of intel-common-pkgarch.inc in
>> crystalforest-gladden.conf and crystalforest-server.conf.
>> As we would like to have control over preferred linux-yocto
>> version for machine specific build.
>>
>> Signed-off-by: Chan Wei Sern <wei.sern.chan at intel.com>
>> ---
>>   meta-crystalforest/conf/machine/crystalforest-gladden.conf |    1 -
>>   meta-crystalforest/conf/machine/crystalforest-server.conf  |    1 -
>>   2 files changed, 2 deletions(-)
>>
>> diff --git a/meta-crystalforest/conf/machine/crystalforest-gladden.conf
>>b/meta-crystalforest/conf/machine/crystalforest-gladden.conf
>> index 9c33293..c1b552a 100644
>> --- a/meta-crystalforest/conf/machine/crystalforest-gladden.conf
>> +++ b/meta-crystalforest/conf/machine/crystalforest-gladden.conf
>> @@ -12,7 +12,6 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-yocto"
>>   PREFERRED_VERSION_linux-yocto ?= "3.10%"
>>   
>>   require conf/machine/include/intel-corei7-64-common.inc
>> -require conf/machine/include/intel-common-pkgarch.inc
>>   require conf/machine/include/meta-intel.inc
>>   
>>   XSERVER ?= "${XSERVER_X86_BASE} \
>> diff --git a/meta-crystalforest/conf/machine/crystalforest-server.conf
>>b/meta-crystalforest/conf/machine/crystalforest-server.conf
>> index fd0e80a..7a5da09 100644
>> --- a/meta-crystalforest/conf/machine/crystalforest-server.conf
>> +++ b/meta-crystalforest/conf/machine/crystalforest-server.conf
>> @@ -12,7 +12,6 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-yocto"
>>   PREFERRED_VERSION_linux-yocto ?= "3.10%"
>>   
>>   require conf/machine/include/intel-corei7-64-common.inc
>> -require conf/machine/include/intel-common-pkgarch.inc
>>   require conf/machine/include/meta-intel.inc
>>   
>>   XSERVER ?= "${XSERVER_X86_BASE} \
>
>


-- 
Darren Hart					Open Source Technology Center
darren.hart at intel.com				            Intel Corporation