[meta-intel] [PATCH 2/2] meta-valleyisland: include Intel I915 Xorg driver to machine conf file

[Kamble, Nitin A]

Hi Rebecca,

   My review comments below.


On 3/26/2014 10:07 AM, Rebecca.swee.fun.chang at intel.com wrote:
> From: Chang Rebecca Swee Fun <rebecca.swee.fun.chang at intel.com>
>
> The image built was found using unaccelerated FBDEV drivers for graphics
> rendering. This can be fix by appending ${XSERVER_IA32_I915} to XSERVER
> variable.
>
> Signed-off-by: Chang Rebecca Swee Fun <rebecca.swee.fun.chang at intel.com>
> ---
>   meta-isg/meta-valleyisland/conf/machine/valleyisland-32.conf |    1 +
>   meta-isg/meta-valleyisland/conf/machine/valleyisland-64.conf |    1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/meta-isg/meta-valleyisland/conf/machine/valleyisland-32.conf b/meta-isg/meta-valleyisland/conf/machine/valleyisland-32.conf
> index 1d0901f..c883b01 100644
> --- a/meta-isg/meta-valleyisland/conf/machine/valleyisland-32.conf
> +++ b/meta-isg/meta-valleyisland/conf/machine/valleyisland-32.conf
> @@ -15,6 +15,7 @@ PREFERRED_VERSION_linux-yocto ?= "3.8%"
>   XSERVER ?= "${XSERVER_IA32_BASE} \
>               ${XSERVER_IA32_EXT} \
>               ${XSERVER_IA32_FBDEV} \
If i915 X driver is working, then there is no need to also include fbdev 
X driver here. Do you have any reason to include fbdev along with i915 here?


> +            ${XSERVER_IA32_I915} \
>              "
>   
>   APPEND += "acpi_enforce_resources=lax video=efifb vga=0x318"
> diff --git a/meta-isg/meta-valleyisland/conf/machine/valleyisland-64.conf b/meta-isg/meta-valleyisland/conf/machine/valleyisland-64.conf
> index 979d1b6..8ed992e 100644
> --- a/meta-isg/meta-valleyisland/conf/machine/valleyisland-64.conf
> +++ b/meta-isg/meta-valleyisland/conf/machine/valleyisland-64.conf
> @@ -17,6 +17,7 @@ PREFERRED_VERSION_linux-yocto ?= "3.8%"
>   XSERVER ?= "${XSERVER_IA32_BASE} \
>               ${XSERVER_IA32_EXT} \
>               ${XSERVER_IA32_FBDEV} \
Same comment here as above.
Thanks,
Nitin

> +            ${XSERVER_IA32_I915} \
>              "
>   
>   APPEND += "acpi_enforce_resources=lax video=efifb vga=0x318"