[meta-intel] [PATCHv2 4/5] meta-valleyisland: add kernel recipe for valleyisland

[Darren Hart]

On 3/24/14, 10:57, "rebecca.swee.fun.chang at intel.com"
<rebecca.swee.fun.chang at intel.com> wrote:

>From: Chang Rebecca Swee Fun <rebecca.swee.fun.chang at intel.com>
>
>Provide kernel v3.10 recipe for valleyisland BSP. Valley Island
>BSP supports ACPI mode enumeration for its LPSS I/O devices. As PCI
>related code are under development in feature branch, user will not
>able to access LPSS I/O device drivers in PCI mode at this moment.
>Using _pn to set SRCREV of meta branch and machine branch globally.
>
>Signed-off-by: Chang Rebecca Swee Fun <rebecca.swee.fun.chang at intel.com>
>---
> .../recipes-kernel/linux/linux-yocto_3.10.bbappend |   27
>++++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644
>meta-isg/meta-valleyisland/recipes-kernel/linux/linux-yocto_3.10.bbappend
>
>diff --git 
>a/meta-isg/meta-valleyisland/recipes-kernel/linux/linux-yocto_3.10.bbappen
>d 
>b/meta-isg/meta-valleyisland/recipes-kernel/linux/linux-yocto_3.10.bbappen
>d
>new file mode 100644
>index 0000000..a0d7b92
>--- /dev/null
>+++ 
>b/meta-isg/meta-valleyisland/recipes-kernel/linux/linux-yocto_3.10.bbappen
>d
>@@ -0,0 +1,27 @@
>+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>+
>+#############################
>+# MACHINE = valleyisland-32 #
>+#############################
>+COMPATIBLE_MACHINE_valleyisland-32 = "valleyisland-32"
>+KMACHINE_valleyisland-32 = "valleyisland-32"
>+KBRANCH_valleyisland-32 = "standard/base"
>+KERNEL_FEATURES_valleyisland-32 =
>"features/valleyisland-io/valleyisland-io"
>+
>+LINUX_VERSION_valleyisland-32 = "3.10.32"
>+SRCREV_machine_pn-linux-yocto_valleyisland-32 ?=
>"61dde96f97bb5b1ed4c11caf9a857d55ad8f6e17"
>+SRCREV_meta_pn-linux-yocto_valleyisland-32 ?=
>"99c503a92885060bebf2bba6747735e8e9346a40"


With respect the need for pn-linux-yocto here, this is because all the
other SRCREV_machine* in meta-intel are using = instead of ?=. This won't
get set because the base linux-yocto recipe specifies a SRCREV, so the ?=
will no override it. The pn-linux-yocto provides a more specific value
which has not yet been set, so it sticks and gets applied.

Just for consistency, the right answer is probably to use = instead of ?=
and drop the pn-linux-yocto.

I do not really care for have "=" in the bbappend honestly. I wonder if
Paul would have another recommendation here...

-- 
Darren Hart
Yocto Project - Linux Kernel
Intel Open Source Technology Center