[meta-intel] [PATCH 4/6] lms7: update the source download URL

[Kamble, Nitin A]

> -----Original Message-----
> From: Hart, Darren
> Sent: Wednesday, March 05, 2014 11:08 PM
> To: Kamble, Nitin A; Zanussi, Tom; meta-intel at yoctoproject.org
> Subject: Re: [PATCH 4/6] lms7: update the source download URL
> 
> On 3/5/14, 20:58, "Kamble, Nitin A" <nitin.a.kamble at intel.com> wrote:
> 
> >
> >On 3/5/2014 7:48 PM, Hart, Darren wrote:
> >> On 3/5/14, 17:58, "Kamble, Nitin A" <nitin.a.kamble at intel.com> wrote:
> >>
> >>> From: Nitin A Kamble <nitin.a.kamble at intel.com>
> >>>
> >>> The old URL is not working anymore. Using a new URL for source zip
> >>>file.
> >>>
> >>> Signed-off-by: Nitin A Kamble <nitin.a.kamble at intel.com>
> >>> ---
> >>> common/recipes-bsp/amt/lms7_7.1.20.bb | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/common/recipes-bsp/amt/lms7_7.1.20.bb
> >>> b/common/recipes-bsp/amt/lms7_7.1.20.bb
> >>> index 9bc9ef1..261f968 100644
> >>> --- a/common/recipes-bsp/amt/lms7_7.1.20.bb
> >>> +++ b/common/recipes-bsp/amt/lms7_7.1.20.bb
> >>> @@ -8,7 +8,7 @@ LICENSE = "BSD_LMS"
> >>> PR = "r0"
> >>> BPN="lms"
> >>> PV_SUB = "25"
> >>> -SRC_URI =
> >>>
> >>>"http://software.intel.com/file/37962;downloadfilename=${BPN}+${PV}.
> $
> >>>{PV
> >>>_S
> >>> UB}.zip \
> >>> +SRC_URI =
> >>>
> >>>"http://software.intel.com/sites/default/files/m/4/e/a/9/b/37962-lms_
> >>>7.1
> >>>.2
> >>> 0.25.zip
> >> I suppose there is no real harm in dropping the use of the PR/PV/etc
> >>variables in the URL, but seems a bit odd to do so, any particular
> >>reason  to do so?
> >I copy pasted the actual URL.  The filename is changed too, so there is
> >no fixed naming scheme here to make good use of the variables.
> 
> OK, so doesn't that leave BPN now unused? And BPN basically unused,
> except in do_unpack() where it is used in the tar filename... Which should
> probably match how you refer to it in the SRC_URI.

BPN var is also used in the packaging, so BPN is not left unused. But if it is a concern I can easily revert the SRC_URI filename to use all the variables.

Nitin


> 
> --
> Darren Hart
> Yocto Project - Linux Kernel
> Intel Open Source Technology Center
> 
>