[meta-intel] [Patch v3 5/7] image-ucode.bbclass: a new bbclass for initramfs images

[Richard Purdie]

On Thu, 2014-07-17 at 15:49 -0700, nitin.a.kamble at intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble at intel.com>
> 
> This provides extensions to the image_types and image-live classes to enable
> the initramfs recipes with early microcode support.
> 
> Look at these bbclass files from the oecore layer for context, as this is
> extending functionality available there.
>   meta/classes/image_types.bbclass
>   meta/classes/image_live.bbclass
> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble at intel.com>
> Acked-by: Darren Hart <dvhart at linux.intel.com>
> ---
>  classes/image-ucode.bbclass | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 classes/image-ucode.bbclass
> 
> diff --git a/classes/image-ucode.bbclass b/classes/image-ucode.bbclass
> new file mode 100644
> index 0000000..a0a3240
> --- /dev/null
> +++ b/classes/image-ucode.bbclass
> @@ -0,0 +1,17 @@
> +# This provides extensions to the image_types and image-live classes to enable
> +# the initramfs recipes with early microcode support.
> +#
> +# Look at these bbclass files from the oecore layer for context, as this is
> +# extending functionality available there.
> +#   meta/classes/image_types.bbclass
> +#   meta/classes/image_live.bbclass
> +#
> +
> +# extentions to image_types.bbclass
> +IMAGE_TYPES += "cpio.gz.ucode"
> +COMPRESSIONTYPES += "gz.ucode"
> +COMPRESS_CMD_gz.ucode = "${COMPRESS_CMD_gz}; cat ${EARLY_UCODE_CPIO} ${IMAGE_NAME}.rootfs.${type}.gz > ${IMAGE_NAME}.rootfs.${type}.gz.ucode"
> +COMPRESS_DEPENDS_gz.ucode = "${COMPRESS_DEPENDS_gz}"

Isn't there still a dependency missing here for whatever provides
EARLY_UCODE_CPIO ?

Cheers,

Richard

> +# Extentions to image-live.bbclass
> +EARLY_UCODE_CPIO ?= "${DEPLOY_DIR_IMAGE}/microcode.cpio"