[meta-intel] [PATCH 5/6] meta-valleyisland: add kernel recipe for valleyisland BSP

[Chang, Rebecca Swee Fun]

> -----Original Message-----
> From: Darren Hart [mailto:dvhart at linux.intel.com]
> Sent: 08 February, 2014 2:12 AM
> To: Chang, Rebecca Swee Fun; meta-intel at yoctoproject.org
> Subject: Re: [meta-intel] [PATCH 5/6] meta-valleyisland: add kernel recipe
> for valleyisland BSP
> 
> On 2/5/14, 2:21, "rebecca.swee.fun.chang at intel.com"
> <rebecca.swee.fun.chang at intel.com> wrote:
> 
> >From: "Chang, Rebecca Swee Fun" <rebecca.swee.fun.chang at intel.com>
> >
> >Provide kernel v3.8 recipe for valleyisland BSP.
> >
> >Signed-off-by: Chang, Rebecca Swee Fun
> ><rebecca.swee.fun.chang at intel.com>
> >---
> > .../recipes-kernel/linux/linux-yocto_3.8.bbappend  |   32
> >++++++++++++++++++++
> > 1 file changed, 32 insertions(+)
> > create mode 100644
> >meta-isg/meta-valleyisland/recipes-kernel/linux/linux-yocto_3.8.bbappen
> >d
> >
> >diff --git
> >a/meta-isg/meta-valleyisland/recipes-kernel/linux/linux-yocto_3.8.bbapp
> >end
> >
> >b/meta-isg/meta-valleyisland/recipes-kernel/linux/linux-yocto_3.8.bbapp
> >end
> >new file mode 100644
> >index 0000000..385da96
> >--- /dev/null
> >+++
> >b/meta-isg/meta-valleyisland/recipes-kernel/linux/linux-yocto_3.8.bbapp
> >end
> >@@ -0,0 +1,32 @@
> >+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> >+
> >+KMETA = "meta"
> >+LINUX_VERSION = "3.8.0"
> 
> This isn't really 3.8.0 is it?
> 
> The SRC_REV 6f3e338aa9496cf68ad03a98f66c2e98975829c7 is 3.8.13.
> 
> Also, the LINUX_VERSION should be specified as a machine override (if
> specified at all) so this recipe doesn't pollute any other MACHINE that is built
> with this layer included.
> 
> LINUX_VERSION_valleyisland-32 = "3.8.13"
> LINUX_VERSION_valleyisland-64 = "3.8.13"
> 
Thanks for catching this. Wasn't aware about this. Will changed it to 3.8.13 on next submission
> 
> I only recently observed this problem, it is pervasive in the meta-intel source
> and needs to be fixed. We need to get new additions right on their way in
> though.
> 
> >+
> >+#############################
> >+# MACHINE = valleyisland-32 #
> >+#############################
> >+COMPATIBLE_MACHINE_valleyisland-32 = "valleyisland-32"
> >+KMACHINE_valleyisland-32 = "valleyisland-32"
> >+KBRANCH_valleyisland-32 = "standard/common-pc/base"
> >+KERNEL_FEATURES_valleyisland-32 =
> >"features/valleyisland-io/valleyisland-io"
> >+
> >+SRCREV_machine_pn-linux-yocto_valleyisland-32 ?=
> >"6f3e338aa9496cf68ad03a98f66c2e98975829c7"
> >+SRCREV_meta_pn-linux-yocto_valleyisland-32 ?=
> >"f87180481b12aebd16b9234d922d5f4a25a32dca"
> >+
> >+SRC_URI_valleyisland-32 =
> >"git://git.yoctoproject.org/linux-yocto-3.8.git;protocol=git;nocheckout
> >=1; branch=${KBRANCH},${KMETA};name=machine,meta"
> >+
> >+#############################
> >+# MACHINE = valleyisland-64 #
> >+#############################
> >+COMPATIBLE_MACHINE_valleyisland-64 = "valleyisland-64"
> >+KMACHINE_valleyisland-64 = "valleyisland"
> >+KBRANCH_valleyisland-64 = "standard/common-pc-64/base"
> >+KERNEL_FEATURES_valleyisland-32 =
> >"features/valleyisland-io/valleyisland-io"
> >+
> >+SRCREV_machine_pn-linux-yocto_valleyisland-64 ?=
> >"6f3e338aa9496cf68ad03a98f66c2e98975829c7"
> >+SRCREV_meta_pn-linux-yocto_valleyisland-64 ?=
> >"f87180481b12aebd16b9234d922d5f4a25a32dca"
> >+
> >+SRC_URI_valleyisland-64 =
> >"git://git.yoctoproject.org/linux-yocto-3.8.git;protocol=git;nocheckout
> >=1; branch=${KBRANCH},${KMETA};name=machine,meta"
> >+
> >+module_autoload_i2c-dev = "i2c-dev"
> >--
> 
> That's an odd single driver to autoload - was that intentional or an artifact
> from development? It's fine if intentional, just curious.

This was my intention to add the line. In the early stage of development, I found that this i2c-dev doesn't load and it was fix by this line.\

Regarding the xorg.conf in recipes-graphics, the image was booting without graphics if I remove the conf file. Let me try once again to prove I was wrong.

Thanks all for the comment. I will do the changes and resubmit it today.
> 
> --
> Darren
>