[meta-intel] [PATCH 1/7] xf86-video-ast: new recipe for ASPEED Technology Card

[Ong, Boon Leong]

> -----Original Message-----
> From: Burton, Ross [mailto:ross.burton at intel.com]
> Sent: Wednesday, April 02, 2014 7:03 PM
> To: Ong, Boon Leong
> Cc: meta-intel at yoctoproject.org
> Subject: Re: [meta-intel] [PATCH 1/7] xf86-video-ast: new recipe for ASPEED
> Technology Card
> 
> On 2 April 2014 12:45,  <boon.leong.ong at intel.com> wrote:
> > +DEPENDS += "virtual/libx11 libpciaccess"
> 
> Drivers shouldn't be linking to client libraries so you should be able to drop
> libx11 from here.
> 
> > +PR = "r0"
> 
> No need for this, remove.
Ross, thanks for the review. I will make above change in v3 patchset because
I have just sent out v2 after resolving Darren's comment.
> 
> > +COMPATIBLE_HOST = '(i.86.*-linux|x86_64.*-linux)'
> 
> Does this driver really only work on x86 hardware?
I only validate it on x86 hardware. Since this goes under meta-intel, I suppose that is fine? 
Or, should I just remove that line entirely? I was referencing recipe written for mga.    
> 
> Ross