[meta-intel] [PATCH 5/5] meta-haswell-wc: provide a working xorg.conf for haswell-wc BSP

Tom Zanussi tom.zanussi at intel.com
Fri Sep 27 06:10:40 PDT 2013


On Thu, 2013-09-26 at 23:30 -0500, Ong, Boon Leong wrote:
> > -----Original Message-----
> > From: Burton, Ross [mailto:ross.burton at intel.com]
> > Sent: Thursday, September 26, 2013 10:30 PM
> > To: Zanussi, Tom
> > Cc: Ong, Boon Leong; meta-intel at yoctoproject.org
> > Subject: Re: [meta-intel] [PATCH 5/5] meta-haswell-wc: provide a working
> > xorg.conf for haswell-wc BSP
> > 
> > On 26 September 2013 15:27, Tom Zanussi <tom.zanussi at intel.com> wrote:
> > >> Provide a working xorg.conf for haswell-wc BSP.
> > >>
> > >
> > > Is it necessary to have this xorg.conf?
> > >
> > > We've been getting away from specifying an xorg.conf if possible.  See
> > > similar recent commits that do that for similar boards - it would be
> > > nice if you could do the same here.  For example:
> > 
> > Yeah, that xorg.conf is "the default, the default, the default, break hotplug
> > input".  That shouldn't be merged.
> > 
> > Ross
> [Ong, Boon Leong] 
> 	I have confirmed that by removing this layer related to recipes-graphic from meta-haswell-wc, the VGA display is working fine. 
> 	Please kindly omit this patch request ": [meta-intel] [PATCH 5/5] meta-haswell-wc: provide a working xorg.conf for haswell-wc BSP "
> 
> 	Thank you
> 

OK, that's good to know.

Although the changes to the patchset have been minor, would you mind
resubmitting it again but with those changes included i.e. drop this
patch and include the minor commit message change in patch 3?  And when
you resubmit the patches to the list add a 'v2' to the subject e.g.
[PATCH v2 0/5][dylan]: new haswell-wc BSP layer and recipes

The reason for doing this is that it's really easy for maintainers to
lose track of exactly which patches to apply e.g. remember that 3/5 has
a new version and 5/5 shouldn't be applied, and it's much easier to just
have a fresh and definitive series (both an updated branch that exactly
matches what was posted and the revised patches submitted to the list -
don't worry, it doesn't bother anybody to see multiple revisions of a
patchset on the list).

Thanks,

Tom





More information about the meta-intel mailing list