[meta-intel] [PATCH] emgd-driver-bin: Fix RDEPENDS and exclude from world

[Richard Purdie]

On Wed, 2013-09-11 at 09:40 -0700, Darren Hart wrote:
> On Wed, 2013-09-11 at 17:35 +0100, Richard Purdie wrote:
> > One of the drivers links to libva so we need to list it as an RDEPENDS
> > so that when we package, we can ensure any library renaming gets applied
> > correctly. The bug can be seen if you "bitbake emgd-driver-bin", then
> > build an image using that library.
> > 
> > Also exclude these recipes from world since they should get built when
> > needed through the virtual/ mechanism, building them for say a qemux86
> > world build just corrupts the system due the the multiple shlibs providers.
> > 
> > Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> > ---
> > diff --git a/common/recipes-graphics/xorg-driver/emgd-driver-bin_1.16.bb b/common/recipes-graphics/xorg-driver/emgd-driver-bin_1.16.bb
> > index 4cb7b8a..806d16d 100644
> > --- a/common/recipes-graphics/xorg-driver/emgd-driver-bin_1.16.bb
> > +++ b/common/recipes-graphics/xorg-driver/emgd-driver-bin_1.16.bb
> > @@ -18,6 +18,14 @@ LIC_FILES_CHKSUM = "file://${WORKDIR}/${EMGD_LIC_DIR}/License.txt;md5=b54f01caaf
> >  
> >  DEPENDS = "rpm-native xz-native"
> >  RDEPENDS_${PN} = "libxcb-dri2 cairo xserver-xorg"
> > +RDEPENDS_emgd-gst-plugins-mixvideo = "libva-tpi"
> > +
> > +# These libraries shouldn't get installed in world builds unless something
> > +# explicitly depends upon them.
> > +EXCLUDE_FROM_WORLD = "1"
> > +
> > +# These libraries shouldn't get installed in world builds unless something
> > +# explicitly depends upon them.+EXCLUDE_FROM_WORLD = "1"
> 
> The above two lines look like a copy/paste error and should be dropped.
> 
> Otherwise looks good. Thank you RP.
> 
> Reviewed-by: Darren Hart <dvhart at linux.intel.com>

Sorry, I did actually fix that, then sent the previous version :/. I've
included the version without that below.


From: Richard Purdie <richard.purdie at linuxfoundation.org>

One of the drivers links to libva so we need to list it as an RDEPENDS
so that when we package, we can ensure any library renaming gets applied
correctly. The bug can be seen if you "bitbake emgd-driver-bin", then
build an image using that library.

Also exclude these recipes from world since they should get built when
needed through the virtual/ mechanism, building them for say a qemux86
world build just corrupts the system due the the multiple shlibs
providers.

Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
---
diff --git a/common/recipes-graphics/xorg-driver/emgd-driver-bin_1.16.bb b/common/recipes-graphics/xorg-driver/emgd-driver-bin_1.16.bb
index 4cb7b8a..6778ee0 100644
--- a/common/recipes-graphics/xorg-driver/emgd-driver-bin_1.16.bb
+++ b/common/recipes-graphics/xorg-driver/emgd-driver-bin_1.16.bb
@@ -18,6 +18,11 @@ LIC_FILES_CHKSUM = "file://${WORKDIR}/${EMGD_LIC_DIR}/License.txt;md5=b54f01caaf
 
 DEPENDS = "rpm-native xz-native"
 RDEPENDS_${PN} = "libxcb-dri2 cairo xserver-xorg"
+RDEPENDS_emgd-gst-plugins-mixvideo = "libva-tpi"
+
+# These libraries shouldn't get installed in world builds unless something
+# explicitly depends upon them.
+EXCLUDE_FROM_WORLD = "1"
 
 # Add the ABI dependency at package generation time, as otherwise bitbake will
 # attempt to find a provider for it (and fail) when it does the parse.
diff --git a/common/recipes-graphics/xorg-driver/emgd-driver-bin_1.18.bb b/common/recipes-graphics/xorg-driver/emgd-driver-bin_1.18.bb
index b659a8b..ee4a313 100644
--- a/common/recipes-graphics/xorg-driver/emgd-driver-bin_1.18.bb
+++ b/common/recipes-graphics/xorg-driver/emgd-driver-bin_1.18.bb
@@ -18,6 +18,11 @@ LIC_FILES_CHKSUM = "file://${WORKDIR}/${EMGD_LIC_DIR}/License.txt;md5=7ce256e6a3
 
 DEPENDS = "rpm-native xz-native"
 RDEPENDS_${PN} = "libxcb-dri2 cairo xserver-xorg"
+RDEPENDS_emgd-gst-plugins-mixvideo = "libva-tpi"
+
+# These libraries shouldn't get installed in world builds unless something
+# explicitly depends upon them.
+EXCLUDE_FROM_WORLD = "1"
 
 # Add the ABI dependency at package generation time, as otherwise bitbake will
 # attempt to find a provider for it (and fail) when it does the parse.