[meta-intel] [PATCH 2/2] xf86-video-ast: Enable ASPEED Tech Graphic Card

[Burton, Ross]

On 18 November 2013 07:57,  <boon.leong.ong at intel.com> wrote:
> +DEPENDS += "virtual/libx11 drm xf86driproto glproto virtual/libgl libpciaccess"

The configure script doesn't appear to check for GL or DRM but does
check for Xv which you've not listed.  Please start from an empty
DEPENDS and add dependencies from configure.ac.

> +EXTRA_OECONF += "--enable-dri"

configure.ac doesn't define this.

> +PR = "r1"

Should be r0 for an initial recipe, and it's not needed for new
recipes now we have the PR server.

> +COMPATIBLE_HOST = '(i.86.*-linux|x86_64.*-linux)'

Is this actually true or more copy/paste?

> +RDEPENDS_${PN} = "xserver-xorg-module-exa"

This driver doesn't use EXA, it has optional support for XAA.

This looks a lot like a driver recipe that was created by copy-pasting
an existing driver, without any validation.  Please don't do that.

Ross