[meta-intel] [PATCH] gnu-efi: Update patch to fix parallel-make issue
Darren Hart
dvhart at linux.intel.com
Thu May 9 07:36:33 PDT 2013
On 05/09/2013 07:15 AM, Saul Wold wrote:
> The library makefiles were using the lib.a() form which compiles and ar's
> as a pair instead of compiling all and then ar'ing which can parallelize better.
I have 1000 runs of this on each of master, dylan, and danny with 0
errors. The fix is solid.
We should probably split the patch out from the existing
parallel-make.patch since that one has already been submitted to the
maintainer and we should be able to track the patches individually. I'm
happy to make that change.
I know the checksums will catch this, but shouldn't we also bump the PR?
I'm happy to make both changes and commit.
Tom, as a heads up, this is also for dylan and danny.
--
Darren
>
> Signed-off-by: Saul Wold <sgw at linux.intel.com>
> ---
> .../gnu-efi/gnu-efi/parallel-make.patch | 29 ++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/common/recipes-bsp/gnu-efi/gnu-efi/parallel-make.patch b/common/recipes-bsp/gnu-efi/gnu-efi/parallel-make.patch
> index 27c94e8..c81f3ad 100644
> --- a/common/recipes-bsp/gnu-efi/gnu-efi/parallel-make.patch
> +++ b/common/recipes-bsp/gnu-efi/gnu-efi/parallel-make.patch
> @@ -6,6 +6,7 @@ Add a missing dependency which resulted in a race leading to failure
> on larger values of -j.
>
> Signed-off-by: Darren Hart <dvhart at linux.intel.com>
> +Signed-off-by: Saul Wold <sgw at linux.intel.com>
>
> Index: gnu-efi-3.0/Makefile
> ===================================================================
> @@ -20,3 +21,31 @@ Index: gnu-efi-3.0/Makefile
> all: check_gcc $(SUBDIRS)
>
> $(SUBDIRS):
> +Index: gnu-efi-3.0/lib/Makefile
> +===================================================================
> +--- gnu-efi-3.0.orig/lib/Makefile
> ++++ gnu-efi-3.0/lib/Makefile
> +@@ -66,7 +66,8 @@ all: libsubdirs libefi.a
> + libsubdirs:
> + for sdir in $(SUBDIRS); do mkdir -p $$sdir; done
> +
> +-libefi.a: libefi.a($(OBJS))
> ++libefi.a: $(OBJS)
> ++ $(AR) rv $@ $(OBJS)
> +
> + clean:
> + rm -f libefi.a *~ $(OBJS) */*.o
> +Index: gnu-efi-3.0/gnuefi/Makefile
> +===================================================================
> +--- gnu-efi-3.0.orig/gnuefi/Makefile
> ++++ gnu-efi-3.0/gnuefi/Makefile
> +@@ -51,7 +51,8 @@ TARGETS = crt0-efi-$(ARCH).o libgnuefi.a
> +
> + all: $(TARGETS)
> +
> +-libgnuefi.a: libgnuefi.a($(OBJS))
> ++libgnuefi.a: $(OBJS)
> ++ $(AR) rv $@ $(OBJS)
> +
> + clean:
> + rm -f $(TARGETS) *~ *.o $(OBJS)
>
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel
More information about the meta-intel
mailing list