[meta-intel] [PATCH 1/8] chiefriver: update v3.8 kernel repo branch commits

[Bruce Ashfield]

On Fri, Mar 29, 2013 at 12:24 PM, Kamble, Nitin A
<nitin.a.kamble at intel.com> wrote:
>
>
>> -----Original Message-----
>> From: Zanussi, Tom
>> Sent: Friday, March 29, 2013 8:43 AM
>> To: Kamble, Nitin A
>> Cc: Hart, Darren; meta-intel at yoctoproject.org
>> Subject: Re: [PATCH 1/8] chiefriver: update v3.8 kernel repo branch commits
>>
>> On Thu, 2013-03-28 at 16:05 -0700, nitin.a.kamble at intel.com wrote:
>> > From: Nitin A Kamble <nitin.a.kamble at intel.com>
>> >
>> > Signed-off-by: Nitin A Kamble <nitin.a.kamble at intel.com>
>> > ---
>> >  .../recipes-kernel/linux/linux-yocto_3.8.bbappend  |    4 ++--
>> >  1 files changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git
>> > a/meta-chiefriver/recipes-kernel/linux/linux-yocto_3.8.bbappend
>> > b/meta-chiefriver/recipes-kernel/linux/linux-yocto_3.8.bbappend
>> > index cbbf5ff..d8f141f 100644
>> > --- a/meta-chiefriver/recipes-kernel/linux/linux-yocto_3.8.bbappend
>> > +++ b/meta-chiefriver/recipes-kernel/linux/linux-yocto_3.8.bbappend
>> > @@ -6,5 +6,5 @@ KBRANCH_chiefriver = "standard/common-pc-
>> 64/chiefriver"
>> >
>> >  KERNEL_FEATURES_append_chiefriver = " features/amt/mei"
>> >
>> > -SRCREV_machine_chiefriver =
>> "b170394a475b96ecc92cbc9e4b002bed0a9f69c5"
>> > -SRCREV_meta_chiefriver =
>> "c2ed0f16fdec628242a682897d5d86df4547cf24"
>> > +SRCREV_machine_chiefriver =
>> "47aed0c17c1c55988198ad39f86ae88894c8e0a4"
>> > +SRCREV_meta_chiefriver =
>> "2a6d36e75ca0a121570a389d7bab76ec240cbfda"
>>
>> Hi Nitin,
>>
>> As part of pinning down the SRCREVS, you should also be specifying the
>> LINUX_VERSION that they correspond to e.g. for this SRCREV:
>>
>> LINUX_VERSION = "3.8.4"
>>
>> Otherwise when the kernel recipe in poky/meta gets its LINUX_VERSION
>> bumped, it will no longer match the version your SRCREV represents and
>> you'll have a PV that uses a different version from your branch...
>>
>> Tom
>>
>
>
> I am adding these LINUX_VERSION lines to this commits now.
>
> Bruce,
>   I see a possibility of improvement here. Is it possible to get the value of this var automatically from one of the kernel scripts?
>

It's chicken and egg .. that's part of the packages version, which is
determined before
the kernel is actually built. There's the abiversion file that other
packages can use, but
not the kernel package itself.

I always want to be explicit in the kernel version, so setting the
variable is less work
than the SRCREVs and has never caused me a problem.

Bruce

> Thanks,
> Nitin
>
>
>
> _______________________________________________
> meta-intel mailing list
> meta-intel at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-intel



--
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"