[meta-intel] [PATCH 2/9] emenlow: linux-yocto:3.8: switch to emgd-1.18

[Kamble, Nitin A]

> -----Original Message-----
> From: Hart, Darren
> Sent: Thursday, July 18, 2013 2:23 PM
> To: Kamble, Nitin A
> Cc: Zanussi, Tom; meta-intel at yoctoproject.org
> Subject: Re: [PATCH 2/9] emenlow: linux-yocto:3.8: switch to emgd-1.18
> 
> On Thu, 2013-07-18 at 18:47 +0000, Kamble, Nitin A wrote:
> >
> > > -----Original Message-----
> > > From: Hart, Darren
> > > Sent: Thursday, July 18, 2013 11:42 AM
> > > To: Kamble, Nitin A
> > > Cc: Zanussi, Tom; meta-intel at yoctoproject.org
> > > Subject: Re: [PATCH 2/9] emenlow: linux-yocto:3.8: switch to
> > > emgd-1.18
> > >
> > > On Wed, 2013-07-17 at 12:07 -0700, nitin.a.kamble at intel.com wrote:
> > > > From: Nitin A Kamble <nitin.a.kamble at intel.com>
> > > >
> > > > Update the emgd kernel driver from version 1.16 to 1.18
> > > >
> > > > Signed-off-by: Nitin A Kamble <nitin.a.kamble at intel.com>
> > > > ---
> > > >  meta-emenlow/recipes-kernel/linux/linux-yocto_3.8.bbappend | 14
> > > > +++++++-------
> > > >  1 file changed, 7 insertions(+), 7 deletions(-)
> > > >
> > > > diff --git
> > > > a/meta-emenlow/recipes-kernel/linux/linux-yocto_3.8.bbappend
> > > > b/meta-emenlow/recipes-kernel/linux/linux-yocto_3.8.bbappend
> > > > index 9a50744..fb8d956 100644
> > > > --- a/meta-emenlow/recipes-kernel/linux/linux-yocto_3.8.bbappend
> > > > +++ b/meta-emenlow/recipes-kernel/linux/linux-yocto_3.8.bbappend
> > > > @@ -3,7 +3,7 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> > > >  COMPATIBLE_MACHINE_emenlow = "emenlow"
> > > >  KMACHINE_emenlow = "emenlow"
> > > >  KBRANCH_emenlow = "standard/emenlow"
> > > > -KERNEL_FEATURES_emenlow_append = " features/drm-emgd/drm-
> > > emgd-1.16 cfg/vesafb"
> > > > +KERNEL_FEATURES_emenlow_append = " features/drm-emgd/drm-
> > > emgd-1.18 cfg/vesafb"
> > > >
> > > >  COMPATIBLE_MACHINE_emenlow-noemgd = "emenlow-noemgd"
> > > >  KMACHINE_emenlow-noemgd = "emenlow"
> > > > @@ -12,11 +12,11 @@ KERNEL_FEATURES_emenlow-noemgd_append
> = "
> > > features/drm-gma500/drm-gma600"
> > > >
> > > >  LINUX_VERSION = "3.8.13"
> > > >
> > > > -SRCREV_meta_emenlow =
> > > "acee86ed84e252f1c3af782cc3aa044aaa13e51a"
> > > > -SRCREV_machine_emenlow =
> > > "1f973c0fc8eea9a8f9758f47cf689ba89dbe9a25"
> > > > -SRCREV_emgd_emenlow =
> > > "dd4eb42f0bce51625218da43f77ee4fae179d835"
> > > > +SRCREV_meta_emenlow =
> > > "8ef9136539464c145963ac2b8ee0196fea1c2337"
> > > > +SRCREV_machine_emenlow =
> > > "f20047520a57322f05d95a18a5fbd082fb15cb87"
> > >
> > >
> > > This does more than update the driver version. BY changing the
> > > machine commit ID, you are also changing the base kernel, but that
> > > isn't mentioned in the commit header. I can understand wanting to do
> > > both in the same go, although ideally the machine commit would be
> > > updated independently from the emgd commit, assuming they are not
> > > dependent on one another. Same goes for all the BSP patches that
> follow.
> >
> > Right, when I updated the meta & emgd branch commit ids, at the same
> > time, I also updated the machine branch commit Ids. It is not necessary, but
> a helpful thing.
> 
> Did you change the minor or stable revision in doing so?

There is no version change of the kernel. 

> 
> This really should be a separate commit. As it is, if there is a failure, we can't
> bisect to determine if it was machine commit, meta commit, or emgd commit
> that broke things. Obviously meta and emgd need to come together.
> 
> Small, distinct, functional changes. All of which need to referenced in the
> commit message.
> 

Ok, I will split the commits accordingly.

Nitin


> --
> Darren
> 
> >
> > Thanks,
> > Nitin
> >
> > >
> > >
> > >
> > > > +SRCREV_emgd_emenlow =
> > > "a18cbb7a2886206815dbf6c85caed3cb020801e0"
> > > >
> > > > -SRCREV_meta_emenlow-noemgd =
> > > "acee86ed84e252f1c3af782cc3aa044aaa13e51a"
> > > > -SRCREV_machine_emenlow-noemgd =
> > > "1f973c0fc8eea9a8f9758f47cf689ba89dbe9a25"
> > > > +SRCREV_meta_emenlow-noemgd =
> > > "8ef9136539464c145963ac2b8ee0196fea1c2337"
> > > > +SRCREV_machine_emenlow-noemgd =
> > > "f20047520a57322f05d95a18a5fbd082fb15cb87"
> > > >
> > > > -SRC_URI_emenlow = "git://git.yoctoproject.org/linux-yocto-
> > > 3.8.git;protocol=git;nocheckout=1;branch=${KBRANCH},${KMETA},emgd-
> > > 1.16;name=machine,meta,emgd"
> > > > +SRC_URI_emenlow = "git://git.yoctoproject.org/linux-yocto-
> > > 3.8.git;protocol=git;nocheckout=1;branch=${KBRANCH},${KMETA},emgd-
> > > 1.18;name=machine,meta,emgd"
> > >
> > > --
> > > Darren Hart
> > > Intel Open Source Technology Center
> > > Yocto Project - Linux Kernel
> > >
> >
> 
> --
> Darren Hart
> Intel Open Source Technology Center
> Yocto Project - Linux Kernel
>