[meta-intel] [PATCH 4/5] fri2.conf: fix boot time kernel errors

[Kamble, Nitin A]

> -----Original Message-----
> From: Zanussi, Tom
> Sent: Thursday, January 31, 2013 12:43 PM
> To: Kamble, Nitin A
> Cc: Hart, Darren; meta-intel at yoctoproject.org
> Subject: Re: [PATCH 4/5] fri2.conf: fix boot time kernel errors
> 
> On Thu, 2013-01-31 at 14:36 -0600, Kamble, Nitin A wrote:
> >
> > > -----Original Message-----
> > > From: Zanussi, Tom
> > > Sent: Thursday, January 31, 2013 12:33 PM
> > > To: Kamble, Nitin A
> > > Cc: Hart, Darren; meta-intel at yoctoproject.org
> > > Subject: Re: [PATCH 4/5] fri2.conf: fix boot time kernel errors
> > >
> > > On Thu, 2013-01-31 at 12:15 -0600, Kamble, Nitin A wrote:
> > > >
> > > > > -----Original Message-----
> > > > > From: Hart, Darren
> > > > > Sent: Thursday, January 31, 2013 8:17 AM
> > > > > To: Kamble, Nitin A
> > > > > Cc: Zanussi, Tom; meta-intel at yoctoproject.org
> > > > > Subject: Re: [PATCH 4/5] fri2.conf: fix boot time kernel errors
> > > > >
> > > > > On 01/30/2013 01:59 PM, nitin.a.kamble at intel.com wrote:
> > > > > > From: Nitin A Kamble <nitin.a.kamble at intel.com>
> > > > > >
> > > > > > The fri2 kernel is hitting kernel BUGs while booting. See the
> > > > > > YP bug
> > > > > > #3810 for more details.
> > > > >
> > > > > Please include details of the BUGs in the commit message.
> > > > Ok, That will make the commit message bit longer.
> > > >
> > > > >
> > > > > >
> > > > > > FRI2 has 1GB of ram, hence the kernel sets 128MB for the
> > > > > > vmalloc allocation memory. And the emgd driver needs at least
> > > > > > 256MB vmalloc memory to work correctly. This commit specifies
> > > > > > the vmalloc allocation size to the kernel by the vmalloc=256MB
> > > > > > boot
> > > parameter.
> > > > > >
> > > > > > Adjusting the kernel's vmalloc allocation size fixes the kernel errors.
> > > > > >
> > > > >
> > > > > OK.... why haven't we seen this in the past? We shipped a ton of
> > > > > these which didn't see this. Has something else changed
> > > > > recently? EMGD
> > > version maybe?
> > > >
> > > >
> > > > I have seen this in the past with crownbay or emenlow BSPs which
> > > > also use EMGD for graphics. Also the emgd is updated to 1.16 now,
> > > > may be it is more aggressive with memory allocation.
> > > >
> > >
> > > Hmm, I just saw your patch upgrading fri2 to emgd 1.16 - so was this
> > > tested with 1.14 or 1.16?  And did the bug occur with 1.14 or 1.16?
> > >
> > > Tom
> > >
> >
> >
> >     The fix for the memory allocation issue is for both versions of EMGD.
> >
> 
> Sure, but I was asking if this bug was reported for 1.14 and tested with
> 1.14 or did it happen with/was tested with 1.16, which would indicate a
> change from past observed behavior.  Useful information, you know.
> 


Tom, 
   As I said before, the fix is needed for both versions of EMGD. I observed it for 1.14 and also for 1.16.
I guess you were lucky to not hit the issue so far. I had similar experience with crownbay. I did not see
these issues initially, but these issues did show up later. I am surprised how you did not see the issue
on FRI2 so far. Does your FRI2 have more ram? And how often was it tested with the EMGD stack?

Nitin



> Tom
> 
> > Nitin
> >
> > > > >
> > > > > > This fixes bug:
> > > > > > [Yocto #3810]
> > > > > >
> > > > > > Signed-off-by: Nitin A Kamble <nitin.a.kamble at intel.com>
> > > > > > ---
> > > > > >  meta-fri2/conf/machine/fri2.conf |    2 +-
> > > > > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > > > >
> > > > > > diff --git a/meta-fri2/conf/machine/fri2.conf
> > > > > > b/meta-fri2/conf/machine/fri2.conf
> > > > > > index 40f2cdc..6ee2335 100644
> > > > > > --- a/meta-fri2/conf/machine/fri2.conf
> > > > > > +++ b/meta-fri2/conf/machine/fri2.conf
> > > > > > @@ -37,4 +37,4 @@ SERIAL_CONSOLE = "115200 ttyPCH1"
> > > > > >  APPEND += "console=ttyPCH1,115200 console=tty0"
> > > > > >
> > > > > >  # EFI boot will ignore this and use the EFI framebuffer at
> > > > > > 800x600
> > > > >
> > > > > This comment needs to be updated. Perhaps adding vmalloc on a
> > > > > separate line would make it clearer. The vmalloc line
> > > > > specifically needs to be documented.
> > > > Ok, will split the line.
> > > >
> > > > Thanks,
> > > > Nitin
> > > >
> > > >
> > > > >
> > > > > > -APPEND += "video=vesafb vga=0x318"
> > > > > > +APPEND += "video=vesafb vga=0x318 vmalloc=256MB"
> > > > > >
> > > > >
> > > > > --
> > > > > Darren Hart
> > > > > Intel Open Source Technology Center Yocto Project - Linux Kernel
> > >
> >
>