[meta-freescale] [PATCH v2 2/2] wayland-protocols: Fix PACKAGE_ARCH for i.MX-specific version

[Gary Bisson]

Hi,

On Tue, Sep 11, 2018 at 9:44 AM, Andreas Müller <schnitzeltony at gmail.com> wrote:
> On Mon, Sep 10, 2018 at 11:21 PM, Tom Hochstein <tom.hochstein at nxp.com> wrote:
>> Fix the PACKAGE_ARCH so that our i.MX-specific version does not
>> override the standard allarch version.
>>
>> Signed-off-by: Tom Hochstein <tom.hochstein at nxp.com>
>> ---
>>  recipes-graphics/wayland/wayland-protocols_1.13.imx.bb | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/recipes-graphics/wayland/wayland-protocols_1.13.imx.bb b/recipes-graphics/wayland/wayland-protocols_1.13.imx.bb
>> index c2ea68e..c722371 100644
>> --- a/recipes-graphics/wayland/wayland-protocols_1.13.imx.bb
>> +++ b/recipes-graphics/wayland/wayland-protocols_1.13.imx.bb
>> @@ -17,7 +17,9 @@ SRC_URI[md5sum] = "29312149dafcd4a0e739ba94995a574d"
>>  SRC_URI[sha256sum] = "0758bc8008d5332f431b2a84fea7de64d971ce270ed208206a098ff2ebc68f38"
>>  S = "${WORKDIR}/${ARCHIVE_NAME}"
>>
>> -inherit allarch autotools pkgconfig
>> +inherit autotools pkgconfig
>>
>>  PACKAGES = "${PN}"
>>  FILES_${PN} += "${datadir}/pkgconfig/wayland-protocols.pc"
>> +
>> +PACKAGE_ARCH = "${MACHINE_SOCARCH}"
>> --
>> 2.7.4
>>
>> --
> This does not fix the problem. Tested for:
>
> * MACHINE = "imx6qdl-variscite-som" / MACHINEOVERRIDES .= ":use-mainline-bsp"
> * raspberrypi3
>
> For both is builds wayland-protocols_1.13.imx. So now the situation is
> even worth: It builds fine but the wrong version of wayland protocols.
> I think we need something like wayland-protocols-imx and
> PREFERRED_PROVIDER solution

The preferred_provider should indeed fix the use-mainline-bsp usecase.

However I wonder why we need such recipe, wouldn't a bbappend to the
wayland protocol recipe be sufficient?

Looking at the patches, they could actually be brought down to 2 patches:
1- add hdr10-metadata protocol
2- add alpha-compositing protocol

Those patches really are not intrusive so I'm pretty sure they'd apply
nicely on any version of wayland-protocol.

Or maybe using the upstream version breaks things?

As a FYI, I revived the alpha-compositing thread upstream so that it
could be merged someday [1].

Tom, is there any plan to upstream the hdr10-metadata protocol?

Regards,
Gary

[1] https://patchwork.freedesktop.org/patch/170804/