[meta-freescale] [PATCH v2 07/19] imx-base.inc: Add imxdpu and imxdpublit to MACHINEOVERRIDES_EXTENDER

Wed Jun 27 05:44:36 PDT 2018

Sorry for the confusion, this design is not quite ready. The original idea was to separate legacy as 'dpublit' and mx8 as 'dpu', although now we plan to offer 'GPU-G2D' for all mx8 as well. I'll simplify it for now and then talk with Prabhu when he gets back from vacation in a couple of weeks.

Tom

-----Original Message-----
From: Otavio Salvador [mailto:otavio.salvador at ossystems.com.br] 
Sent: Wednesday, June 27, 2018 7:24 AM
To: Gary Bisson <gary.bisson at boundarydevices.com>
Cc: Otavio Salvador <otavio at ossystems.com.br>; meta-freescale Mailing List <meta-freescale at yoctoproject.org>; Tom Hochstein <tom.hochstein at nxp.com>
Subject: Re: [meta-freescale] [PATCH v2 07/19] imx-base.inc: Add imxdpu and imxdpublit to MACHINEOVERRIDES_EXTENDER

Cc +Tom

On Wed, Jun 27, 2018 at 6:07 AM, Gary Bisson <gary.bisson at boundarydevices.com> wrote:
> Hi,
>
> I still do not understand that patch.
>
> On Tue, Jun 26, 2018 at 02:37:16PM -0300, Otavio Salvador wrote:
>> From: Tom Hochstein <tom.hochstein at nxp.com>
>>
>> - imx-gpu-g2d requires DPU-blit support
>> - imx-dpu-g2d requires DPU support
>>
>> Signed-off-by: Tom Hochstein <tom.hochstein at nxp.com>
>> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>> ---
>>
>>  conf/machine/include/imx-base.inc                  | 14 +++++++-------
>>  recipes-graphics/imx-dpu-g2d/imx-dpu-g2d_1.4.2.bb  |  4 +++-
>>  .../imx-gpu-g2d/imx-gpu-g2d_6.2.4.p1.2.bb          |  4 +++-
>>  3 files changed, 13 insertions(+), 9 deletions(-)
>>
>> diff --git a/conf/machine/include/imx-base.inc 
>> b/conf/machine/include/imx-base.inc
>> index 2e8f03a6..2bf79541 100644
>> --- a/conf/machine/include/imx-base.inc
>> +++ b/conf/machine/include/imx-base.inc
>> @@ -59,17 +59,17 @@ DEFAULTTUNE_vf ?= "cortexa5thf-neon"
>>  INHERIT += "machine-overrides-extender"
>>
>>  MACHINEOVERRIDES_EXTENDER_mx25   = "use-mainline-bsp"
>> -MACHINEOVERRIDES_EXTENDER_mx6q   = "imxipu:imxvpu:imxgpu2d:imxgpu3d"
>> -MACHINEOVERRIDES_EXTENDER_mx6dl  = "imxpxp:imxipu:imxvpu:imxgpu2d:imxgpu3d:imxepdc"
>> -MACHINEOVERRIDES_EXTENDER_mx6sx  = "imxpxp:imxgpu2d:imxgpu3d"
>> -MACHINEOVERRIDES_EXTENDER_mx6sl  = "imxpxp:imxgpu2d:imxepdc"
>> +MACHINEOVERRIDES_EXTENDER_mx6q   = "imxipu:imxvpu:imxgpu2d:imxdpublit:imxgpu3d"
>> +MACHINEOVERRIDES_EXTENDER_mx6dl  = "imxpxp:imxipu:imxvpu:imxgpu2d:imxdpublit:imxgpu3d:imxepdc"
>> +MACHINEOVERRIDES_EXTENDER_mx6sx  = "imxpxp:imxgpu2d:imxdpublit:imxgpu3d"
>> +MACHINEOVERRIDES_EXTENDER_mx6sl  = "imxpxp:imxgpu2d:imxdpublit:imxepdc"
>>  MACHINEOVERRIDES_EXTENDER_mx6sll = "imxpxp:imxepdc"
>>  MACHINEOVERRIDES_EXTENDER_mx6ul  = "imxpxp"
>>  MACHINEOVERRIDES_EXTENDER_mx6ull = "imxpxp:imxepdc"
>>  MACHINEOVERRIDES_EXTENDER_mx7d   = "imxpxp:imxepdc"
>> -MACHINEOVERRIDES_EXTENDER_mx7ulp = "imxpxp:imxgpu2d:imxgpu3d"
>> -MACHINEOVERRIDES_EXTENDER_mx8mq  = "imxvpu:imxgpu3d"
>> -MACHINEOVERRIDES_EXTENDER_mx8mm  = "imxvpu:imxgpu2d:imxgpu3d"
>> +MACHINEOVERRIDES_EXTENDER_mx7ulp = "imxpxp:imxgpu2d:imxdpublit:imxgpu3d"
>> +MACHINEOVERRIDES_EXTENDER_mx8mq  = "imxvpu:imxdpu:imxgpu3d"
>
> i.MX8MQ doesnt have a DPU, imx-dpu-g2d_1.4.2 should NOT be built for 
> this platform.
>
>> +MACHINEOVERRIDES_EXTENDER_mx8mm  = "imxvpu:imxgpu2d:imxdpu:imxgpu3d"
>>
>>  MACHINEOVERRIDES_EXTENDER_FILTER_OUT_use-mainline-bsp = " \
>>      mx6 \
>> diff --git a/recipes-graphics/imx-dpu-g2d/imx-dpu-g2d_1.4.2.bb 
>> b/recipes-graphics/imx-dpu-g2d/imx-dpu-g2d_1.4.2.bb
>> index dd3aa9dd..9a89fa66 100644
>> --- a/recipes-graphics/imx-dpu-g2d/imx-dpu-g2d_1.4.2.bb
>> +++ b/recipes-graphics/imx-dpu-g2d/imx-dpu-g2d_1.4.2.bb
>> @@ -34,4 +34,6 @@ INSANE_SKIP_${PN} += "ldflags"
>>  FILES_${PN} = "${libdir}/libg2d* /opt"
>>  FILES_${PN}-dev = "${libdir}/libg2d${SOLIBSDEV} ${includedir}"
>>
>> -COMPATIBLE_MACHINE = "(mx8mm)"
>> +# Compatible only with i.MX DPU
>> +COMPATIBLE_MACHINE = "(^$)"
>> +COMPATIBLE_MACHINE_imxdpu = "${MACHINE}"
>> diff --git a/recipes-graphics/imx-gpu-g2d/imx-gpu-g2d_6.2.4.p1.2.bb 
>> b/recipes-graphics/imx-gpu-g2d/imx-gpu-g2d_6.2.4.p1.2.bb
>> index eab1d31b..a4dbe4e3 100644
>> --- a/recipes-graphics/imx-gpu-g2d/imx-gpu-g2d_6.2.4.p1.2.bb
>> +++ b/recipes-graphics/imx-gpu-g2d/imx-gpu-g2d_6.2.4.p1.2.bb
>> @@ -35,4 +35,6 @@ FILES_${PN} = "${libdir}/libg2d* /opt"
>>  FILES_${PN}-dev = "${includedir}"
>>  INSANE_SKIP_${PN} = "ldflags"
>>
>> -COMPATIBLE_MACHINE = "(mx6|mx7ulp)"
>> +# Compatible only with i.MX DPU-blit
>
> What? The DPU naming is highly confusing, do you mean that the CPU is 
> capable of doing 2D blit?
>
>> +COMPATIBLE_MACHINE = "(^$)"
>> +COMPATIBLE_MACHINE_imxdpublit = "${MACHINE}"
>
> Why not using:
> COMPATIBLE_MACHINE_imxgpu2d = "${MACHINE}"
>
> Why creating imxdpublit whereas there's already imxgpu2d? Then 
> virtual/libg2d is either provided by imx-gpu-2d or imx-dpu-2d.
>
> Regards,
> Gary
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale at yoctoproject.org
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flis
> ts.yoctoproject.org%2Flistinfo%2Fmeta-freescale&data=02%7C01%7Ctom.hoc
> hstein%40nxp.com%7C81e5c7599c7742e2747d08d5dc28dfc6%7C686ea1d3bc2b4c6f
> a92cd99c5c301635%7C0%7C0%7C636656990475097321&sdata=ShIl30otyKR19qNgoa
> SwF9K9gtVS11CNi7WGTPtvgvs%3D&reserved=0

-- 
Otavio Salvador                             O.S. Systems
https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.ossystems.com.br&data=02%7C01%7Ctom.hochstein%40nxp.com%7C81e5c7599c7742e2747d08d5dc28dfc6%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636656990475097321&sdata=1cJ4EmHtuCHYWOjg4%2BF6XRSWBOvRpXxPvNR7qGpWPjQ%3D&reserved=0        https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcode.ossystems.com.br&data=02%7C01%7Ctom.hochstein%40nxp.com%7C81e5c7599c7742e2747d08d5dc28dfc6%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636656990475097321&sdata=Mh3yrYnUe7FWYN%2FmEomLxqMOeYFECfe5FAjxBOJzSp8%3D&reserved=0
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750