[meta-freescale] [PATCH] wks: add a kickstart file with vfat boot and ext4 rootfs partition

[Stefan Agner]

On 14.09.2017 01:08, Max Krummenacher wrote:
> Hi
>
>
>
> 2017-09-13 23:20 GMT+02:00 Stefan Agner <stefan.agner at toradex.com>:
>> I guess / is a bit different here since it just uses /dev/root, in the end the mmcblk comes from the boot arguments (root=).
>>
>> One could probably just define the proper mmcblkX with the --disk argument, but that does not work since mmcblk devices are not stable. E.g. if you use the second SDHC controller for an eMMC, and the first SDHC controller is available externally for SD cards, you root device is mmcblk0 if there is no SD card available, and mmcblk1 if there is one available.. At least on mainline that is the case. There are patches floating around which provide a more stable block device name. But the official answer is PARTUUID. So I guess one would have to teach wks PARTUUID support for fstab generation...
>>
>> Personally I also like to have /boot mounted to the partition where the kernels are, even if that is an external FAT partition... That is also the case on regular Linux distros booting with UEFI.
>>
>> But Max approach would work around that issue for now until PARTUUID support is available...
>>
>> --
>> Stefan
> As said in the patch this commit to oe-core changed the behaviour of wic.
> http://cgit.openembedded.org/openembedded-core/commit/scripts/lib/wic/plugins/imager/direct.py?id=2376b05512ddb8c4ec3aaf1df11071f536a76bd9
>
> Before that wic added a line to fstab for each partition which had a
> mountpoint set if the mountpoint was not '/' or '/boot'. With the
> patch only '/' is not added to to fstab.
> And the commit text clearly states that this exception is removed
> because a user who does not want that entry can simply omit the
> mountpoint in the kickstarter file.
>
> Which is why I created a new kickstarter file which does exactly what
> the commit text proposes.

Oh I see, the /boot mount support with the sdimage-bootpart.wks is basically broken right now (silently broken for sysv init, and really broken for systemd).

So your change actually fixes what wic broke for the sdcard-bootpart.wks... IMHO we should remove /boot mount point in sdimage-bootpart.wks (which essentially restores old behaviour and makes sure the image works with systemd again)...

One could then later do what I proposed above with the PARTUUID stuff. But that is added feature...

There is still the partition layout for which it might make sense to introduce a meta-freescale specific kickstart file...?

The sdcard-bootpart.wks uses 4KiB alignment. Personally I would prefer 1MiB everywhere, since that is what fstab also does.

--
Stefan