[meta-freescale] [3rdparty][PATCH 07/15] apalis-imx6.conf: add an include file hook

[Stefan Agner]

On 06.09.2017 12:26, Otavio Salvador wrote:
> On Wed, Sep 6, 2017 at 11:12 AM, Max Krummenacher <max.oss.09 at gmail.com> wrote:
>> Add a hook to allow to append to the machine configuration from an optional
>> include file.
>>
>> Signed-off-by: Max Krummenacher <max.krummenacher at toradex.com>
> This is not a good practice. All those can be set on the DISTRO our
> customer layer so please drop this patch for v2.
>

One reason we wanted to add this is because we have some Toradex specific variables which helps our Toradex Easy Installer (tezi) image format (we have a image_type_tezi.bbclass):
TORADEX_PRODUCT_IDS = "0032 0033"
TORADEX_PRODUCT_IDS[0032] = "imx7s-colibri-eval-v3.dtb"
TORADEX_PRODUCT_IDS[0033] = "imx7d-colibri-eval-v3.dtb"
TORADEX_FLASH_TYPE = "rawnand"

We could probably work around it by adding TORADEX_PRODUCT_IDS_$MACHINE variables in local.conf or distro.conf, but this seems the wrong place...

So if it is ok to add those variables upstream, we do not need that customization of machine config.

Another question is whether we should upstream that image_type_tezi.bbclass.. Although, I feel meta-freescale-3rdparty is the wrong place since we need it also for modules with non NXP SoCs.. I'd rather prefer to keep it in our meta-toradex-bsp-common layer.



On another page we also have customer which want to customize machine to some degree. And when you think about it, since it is a module, customers also physically alter machine capabilities...

Some customer end up just copy our machine (and maybe rename) it. But that leads to duplication, and when we alter things which are module specific, he has to merge...

There is SoC and machine abstraction, but module is somehow missing... Not sure how that would have to look if we would want to push it all the way to the end, maybe there should be only a apalis-imx6.inc, with a bunch of MODULE_FEATURES, and the customer has apalis-imx6-my-board.conf, which includes that module.


--
Stefan