[meta-freescale] [meta-freescale PATCH 3/3] qoriq-base.inc: Use 'fsl-dynamic-packagearch' class

[Zhenhua Luo]

Hello Otavio, 

> -----Original Message-----
> From: Otavio Salvador [mailto:otavio at ossystems.com.br]
> Sent: Saturday, September 17, 2016 1:22 AM
> 
> This ensures PACKAGE_ARCH has a better default.
> 
>  - use MACHINE_ARCH for every package depending on virtual/kernel
> 
>  - use MACHINE_SOCARCH for every package depending on
>    cryptodev-qoriq-linux, cryptodev-qoriq-module, cryptodev-qoriq-test
>    or openssl-qoriq;
> 
> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
> ---
> 
>  conf/machine/include/qoriq-base.inc | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/conf/machine/include/qoriq-base.inc b/conf/machine/include/qoriq-
> base.inc
> index 1786b00..7360a75 100644
> --- a/conf/machine/include/qoriq-base.inc
> +++ b/conf/machine/include/qoriq-base.inc
> @@ -17,3 +17,12 @@ MACHINE_EXTRA_RRECOMMENDS += "udev-extraconf
> udev-rules-qoriq kernel-modules"
>  EXTRA_IMAGEDEPENDS += "u-boot cst-native"
> 
>  MACHINEOVERRIDES =. "qoriq:"
> +
> +# Sub-architecture support
> +MACHINE_SOCARCH_SUFFIX ?= ""
> +MACHINE_SOCARCH_SUFFIX_qoriq = "-qoriq"
> +
> +MACHINE_ARCH_FILTER = "virtual/kernel"
[Zhenhua Luo] For the MACHINE_ARCH definition, seems good. 

> +MACHINE_SOCARCH_FILTER_append_qoriq = " cryptodev-qoriq-linux
> cryptodev-qoriq-module cryptodev-qoriq-test openssl-qoriq"
[Zhenhua Luo] I don't understand why the MACHINE_SOCARCH definition is needed for those packages, can you please elaborate? 

> +INHERIT += "fsl-dynamic-packagearch"
[Zhenhua Luo] According to the following code in fsl-dynamic-packagearch.bbclass, the MACHINE_SOCARCH of qoriq-ppc targets will be set to SOCARCH of ARM? This seems to be problematic. 

	ARM_EXTRA_SOCARCH = "${ARMPKGARCH}${ARMPKGSFX_DSP}${ARMPKGSFX_EABI}${ARMPKGSFX_ENDIAN}${ARMPKGSFX_FPU}${MACHINE_SOCARCH_SUFFIX}"
	THUMB_EXTRA_SOCARCH = "${ARMPKGARCH}${ARM_THUMB_SUFFIX}${ARMPKGSFX_DSP}${ARMPKGSFX_EABI}${ARMPKGSFX_ENDIAN}${ARMPKGSFX_FPU}${MACHINE_SOCARCH_SUFFIX}"

	MACHINE_SOCARCH = "${@bb.utils.contains('ARM_INSTRUCTION_SET', 'thumb', '${THUMB_EXTRA_SOCARCH}', '${ARM_EXTRA_SOCARCH}', d)}"


Best Regards, 

Zhenhua