[meta-freescale] [meta-fsl-arm PATCH v2 00/16] Machine overrides extender - reduce code duplication

[Otavio Salvador]

On Mon, Sep 5, 2016 at 10:13 PM, Tom Hochstein <tom.hochstein at nxp.com> wrote:
>> From: Otavio Salvador [mailto:otavio.salvador at ossystems.com.br]
>> Sent: Monday, September 05, 2016 12:18 PM
>
>> I know how this works BUT people assumes machine features are to be
>> enabled/disabled on machine basis, that is the main reason I did not
>> use it.
>
> Okay, so assume we chose to implement using machine features, and a user has disabled a machine feature using MACHINE_FEATURES_remove. I guess he will have no problem (other than his faulty understanding) since the feature will be disabled as he wants. Is there some other problem?
>
>> The way I designed it, the extender is applied on the BSP level so it
>> provides the lift of features the SoC supports. If you want to change
>> something in a recipe or so, it will be applied globally and then
>> making it harder for people to make a frankenstein.
>
> Okay, but an implementation using MACHINE_FEATURES would not be any different. Each machine configuration file would include a new SOC configuration file, like this one for 6 Quad:
>
> GPU_FEATURES = "imxipu imxvpu imxgpu2d imxgpu3d"
> MACHINE_FEATURES += "${GPU_FEATURES}"
> DISTRO_FEATURES_DEFAULT += "${GPU_FEATURES}"

Adding DISTRO things in a machine file is a clear indication something
is wrong. Anything related to distro features cannot be change in
machine level or it makes it incompatible across different machines.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750