[meta-freescale] [meta-fsl-demos][PATCH v3 1/2] packagegroup-imx-tools-audio.bb: Add recipe for new package group.

[Yuqing Zhu]

Hi Daiane,

     Thanks for your feedback.
     The definition of this package group is based on i.MX project and it provides an easy way to install the audio tools for either pulseaudio or alsa based distributions.


B.R.
Carol

-----Original Message-----
From: angolini at gmail.com [mailto:angolini at gmail.com] On Behalf Of Daiane Angolini
Sent: Tuesday, May 10, 2016 7:35 PM
To: Yuqing Zhu <carol.zhu at nxp.com>
Cc: meta-freescale at yoctoproject.org
Subject: Re: [meta-freescale] [meta-fsl-demos][PATCH v3 1/2] packagegroup-imx-tools-audio.bb: Add recipe for new package group.

On Tue, May 10, 2016 at 3:32 AM, Yuqing Zhu <carol.zhu at nxp.com> wrote:
> The package group is used to provide an easy way to install the audio 
> tools for either pulseaudio or alsa based distributions.

Why one would like to use this packagegroup?

Why it is not upstreamed to yocto project's source code instead?

>
> Signed-off-by: Yuqing Zhu <carol.zhu at nxp.com>
> ---
>  .../packagegroups/packagegroup-imx-tools-audio.bb  | 33 
> ++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 
> recipes-fsl/packagegroups/packagegroup-imx-tools-audio.bb
>
> diff --git a/recipes-fsl/packagegroups/packagegroup-imx-tools-audio.bb 
> b/recipes-fsl/packagegroups/packagegroup-imx-tools-audio.bb
> new file mode 100644
> index 0000000..b54e5af
> --- /dev/null
> +++ b/recipes-fsl/packagegroups/packagegroup-imx-tools-audio.bb
> @@ -0,0 +1,33 @@
> +# Copyright (C) 2015 Freescale Semiconductor # Copyright (C) 2015 
> +O.S. Systems Software LTDA.
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +SUMMARY = "Set of audio tools for inclusion on images"

This SUMMARY makes me feel this packagegroup is useless. You could a DESCRIPTION instead, adding what motivated you to create such packagegroup, and maybe adding what problem this packagegroup solves.


> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> +                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> +
> +inherit packagegroup
> +
> +ALSA_INSTALL = " \
> +    alsa-utils \
> +    alsa-tools \
> +"
> +
> +PULSEAUDIO_INSTALL = " \
> +    pulseaudio-server \
> +    pulseaudio-module-cli \
> +    pulseaudio-misc \
> +    pulseaudio-module-device-manager \
> +    ${@bb.utils.contains('DISTRO_FEATURES',"x11", "pulseaudio-module-x11-xsmp \
> +                                                   pulseaudio-module-x11-publish \
> +                                                   pulseaudio-module-x11-cork-request \
> +                                                   pulseaudio-module-x11-bell \
> +                                                   consolekit", \
> +                                           "", d)} \ "
> +
> +RDEPENDS_${PN} = " \
> +    ${@bb.utils.contains("DISTRO_FEATURES", "alsa",  "${ALSA_INSTALL}", "", d)} \
> +    ${@bb.utils.contains("DISTRO_FEATURES", "pulseaudio",  
> +"${PULSEAUDIO_INSTALL}", "", d)} \ "
> --
> 1.9.1
>
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale