[meta-freescale] [meta-fsl-arm][PATCH 7/9] gstreamer1.0-plugins-bad: Add fps print in glimagesink
Pushpal Sidhu
psidhu at gateworks.com
Thu Jan 28 09:10:14 PST 2016
Yuqing,
On Wed, Jan 27, 2016 at 11:22 PM, Yuqing Zhu <carol.zhu at nxp.com> wrote:
> Hi Carlos,
>
>
> Your method seems more formal.
> But this log is necessary and important for us to read GPU performance, so just using g_print directly.
> If you insist on this, we will refine it later.
I am with Carlos. You shouldn't blindly print here with a 'g_print'.
You should instead take Carlos' suggestion or add a debug print (to
use with --gst-debug=glimagesink:4 or something) so the user doesn't
get spammed by non-error messages when using this sink. And yes this
is a 'formal' method, but if anyone wanted to use this plugin for
production use, that's how you would have to code it anyways.
- Pushpal
> B.R.
> Yuqing Zhu
>
> -----Original Message-----
> From: meta-freescale-bounces at yoctoproject.org [mailto:meta-freescale-bounces at yoctoproject.org] On Behalf Of Carlos Rafael Giani
> Sent: Wednesday, January 27, 2016 8:23 PM
> To: meta-freescale at yoctoproject.org
> Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH 7/9] gstreamer1.0-plugins-bad: Add fps print in glimagesink
>
> This seems like a patch for debug output (the number of frames shown so far). This is OK, except that it should not be always enabled, and it should not directly call g_print. Have a look at fpsdisplaysink. It uses the last-message property, a "silent" property, and
> g_object_notify_by_pspec() to send out messages just like fakesink does.
>
> Example:
>
> gst-launch-1.0 videotestsrc ! fpsdisplaysink text-overlay=false silent=false -v
>
> This is how your output should work.
>
>
> On 01/27/2016 10:41 AM, Yuqing Zhu wrote:
>> In GST-1.6, Pipeline will set start time to 0 when state change form
>> PAUSE to READY, so get start time in state change PLAYING_PAUSE.
>>
>> Signed-off-by: Yuqing Zhu <b54851 at freescale.com>
>> ---
>> ...008-glplugin-Add-fps-print-in-glimagesink.patch | 83 ++++++++++++++++++++++
>> .../gstreamer/gstreamer1.0-plugins-bad_%.bbappend | 1 +
>> 2 files changed, 84 insertions(+)
>> create mode 100755
>> recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0008-glplugin-Ad
>> d-fps-print-in-glimagesink.patch
>>
>> diff --git
>> a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0008-glplugin-
>> Add-fps-print-in-glimagesink.patch
>> b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0008-glplugin-
>> Add-fps-print-in-glimagesink.patch
>> new file mode 100755
>> index 0000000..32f78b2
>> --- /dev/null
>> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0008-glplu
>> +++ gin-Add-fps-print-in-glimagesink.patch
>> @@ -0,0 +1,83 @@
>> +From 8b6786fa049e9a5acfd6e7776fe0790c57c9c569 Mon Sep 17 00:00:00
>> +2001
>> +From: Haihua Hu <b55597 at freescale.com>
>> +Date: Wed, 18 Nov 2015 15:10:22 +0800
>> +Subject: [PATCH 1/5] [glplugin] Add fps print in glimagesink
>> +
>> +In GST-1.6, Pipeline will set start time to 0 when state change form
>> +PAUSE to READY, so get start time in state change PLAYING_PAUSE.
>> +
>> +Upstream-Status: Inappropriate [i.MX specific]
>> +
>> +Signed-off-by: Haihua Hu <b55597 at freescale.com>
>> +---
>> + ext/gl/gstglimagesink.c | 15 +++++++++++++++
>> + ext/gl/gstglimagesink.h | 4 ++++
>> + 2 files changed, 19 insertions(+)
>> +
>> +diff --git a/ext/gl/gstglimagesink.c b/ext/gl/gstglimagesink.c index
>> +6fc0f9e..60355ec 100644
>> +--- a/ext/gl/gstglimagesink.c
>> ++++ b/ext/gl/gstglimagesink.c
>> +@@ -587,6 +587,8 @@ gst_glimage_sink_init (GstGLImageSink * glimage_sink)
>> + glimage_sink->overlay_compositor = NULL;
>> + glimage_sink->cropmeta = NULL;
>> + glimage_sink->prev_cropmeta = NULL;
>> ++ glimage_sink->frame_showed = 0;
>> ++ glimage_sink->run_time = 0;
>> +
>> + glimage_sink->mview_output_mode = DEFAULT_MULTIVIEW_MODE;
>> + glimage_sink->mview_output_flags = DEFAULT_MULTIVIEW_FLAGS; @@
>> +-964,7 +966,10 @@ gst_glimage_sink_change_state (GstElement *
>> +element, GstStateChange transition)
>> +
>> + switch (transition) {
>> + case GST_STATE_CHANGE_PLAYING_TO_PAUSED:
>> ++ {
>> ++ glimage_sink->run_time = gst_element_get_start_time
>> ++ (GST_ELEMENT (glimage_sink));
>> + break;
>> ++ }
>> + case GST_STATE_CHANGE_PAUSED_TO_READY:
>> + {
>> + GstBuffer *buf[2];
>> +@@ -1047,6 +1052,14 @@ gst_glimage_sink_change_state (GstElement * element, GstStateChange transition)
>> + g_slice_free(GstVideoCropMeta, glimage_sink->prev_cropmeta);
>> + glimage_sink->prev_cropmeta = NULL;
>> +
>> ++ if (glimage_sink->run_time > 0) {
>> ++ g_print ("Total showed frames (%lld), playing for (%"GST_TIME_FORMAT"), fps (%.3f).\n",
>> ++ glimage_sink->frame_showed, GST_TIME_ARGS (glimage_sink->run_time),
>> ++ (gfloat)GST_SECOND * glimage_sink->frame_showed / glimage_sink->run_time);
>> ++ }
>> ++
>> ++ glimage_sink->frame_showed = 0;
>> ++ glimage_sink->run_time = 0;
>> + break;
>> + default:
>> + break;
>> +@@ -1474,6 +1487,8 @@ gst_glimage_sink_show_frame (GstVideoSink * vsink, GstBuffer * buf)
>> + return GST_FLOW_ERROR;
>> + }
>> +
>> ++ glimage_sink->frame_showed++;
>> ++
>> + return GST_FLOW_OK;
>> +
>> + /* ERRORS */
>> +diff --git a/ext/gl/gstglimagesink.h b/ext/gl/gstglimagesink.h index
>> +a26ca4b..fa69999 100644
>> +--- a/ext/gl/gstglimagesink.h
>> ++++ b/ext/gl/gstglimagesink.h
>> +@@ -120,6 +120,10 @@ struct _GstGLImageSink
>> + GstGLStereoDownmix mview_downmix_mode;
>> +
>> + GstGLOverlayCompositor *overlay_compositor;
>> ++
>> ++ /* fps print support */
>> ++ guint64 frame_showed;
>> ++ GstClockTime run_time;
>> + };
>> +
>> + struct _GstGLImageSinkClass
>> +--
>> +1.7.9.5
>> +
>> diff --git
>> a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend
>> b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend
>> index 40be87a..d3b8c2d 100644
>> --- a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend
>> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend
>> @@ -17,6 +17,7 @@ IMX_PATCHES = " file://0001-PATCH-install-gstaggregator-and-gstvideoaggregator-h
>> file://0005-glplugin-support-video-crop-for-glimagesink.patch \
>> file://0006-glplugin-Support-fb-backend-for-gl-plugins.patch \
>>
>> file://0007-glplugin-Change-wayland-default-res-to-1024x768.patch \
>> +
>> + file://0008-glplugin-Add-fps-print-in-glimagesink.patch \
>> "
>>
>> SRC_URI_append_mx6 = "${IMX_PATCHES}"
>
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
More information about the meta-freescale
mailing list