[meta-freescale] [meta-fsl-arm][PATCH 2/3] gstreamer1.0-plugins-base: Don't set async of custom text-sink to false

Carlos Rafael Giani dv at pseudoterminal.org
Mon Jan 18 06:16:51 PST 2016


Here my question too is: why is this flagged as i.MX specific? Nothing 
in this patch refers to i.MX details such as IPU, VPU..

And you also need a link to a GStreamer bugzilla entry in the commit 
message of this patch.

On 01/18/2016 10:34 AM, Yuqing Zhu wrote:
> Set async to false lead to A/V sync problem when seeking.
> The preroll need use GAP event instead of set async to false.
>
> Signed-off-by: Yuqing Zhu <b54851 at freescale.com>
> ---
>   ...-don-t-set-async-of-custom-text-sink-to-f.patch | 34 ++++++++++++++++++++++
>   .../gstreamer/gstreamer1.0-plugins-base_%.bbappend |  1 +
>   2 files changed, 35 insertions(+)
>   create mode 100755 recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0002-gstplaysink-don-t-set-async-of-custom-text-sink-to-f.patch
>
> diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0002-gstplaysink-don-t-set-async-of-custom-text-sink-to-f.patch b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0002-gstplaysink-don-t-set-async-of-custom-text-sink-to-f.patch
> new file mode 100755
> index 0000000..61dad2f
> --- /dev/null
> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base/0002-gstplaysink-don-t-set-async-of-custom-text-sink-to-f.patch
> @@ -0,0 +1,34 @@
> +From a4672257ddc8f72d528091d20aa2242293adc17a Mon Sep 17 00:00:00 2001
> +From: Mingke Wang <mingke.wang at freescale.com>
> +Date: Thu, 19 Mar 2015 14:15:25 +0800
> +Subject: [PATCH 2/9] gstplaysink: don't set async of custom text-sink to false
> +
> +set async to false lead to A/V sync problem when seeking.
> +the preroll need use GAP event instead of set async to false.
> +
> +Upstream-Status: Inappropriate [i.MX specific]
> +
> +Signed-off-by: Mingke Wang <mingke.wang at freescale.com>
> +---
> + gst/playback/gstplaysink.c | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> + mode change 100644 => 100755 gst/playback/gstplaysink.c
> +
> +diff --git a/gst/playback/gstplaysink.c b/gst/playback/gstplaysink.c
> +old mode 100644
> +new mode 100755
> +index aa43111..e670934
> +--- a/gst/playback/gstplaysink.c
> ++++ b/gst/playback/gstplaysink.c
> +@@ -2431,7 +2431,7 @@ gen_text_chain (GstPlaySink * playsink)
> +           G_TYPE_BOOLEAN);
> +       if (elem) {
> +         /* make sure the sparse subtitles don't participate in the preroll */
> +-        g_object_set (elem, "async", FALSE, NULL);
> ++        //g_object_set (elem, "async", FALSE, NULL);
> +         GST_DEBUG_OBJECT (playsink, "adding custom text sink");
> +         gst_bin_add (bin, chain->sink);
> +         /* NOTE streamsynchronizer needs streams decoupled */
> +--
> +1.9.1
> +
> diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend
> index 3e72175..cf50918 100644
> --- a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend
> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_%.bbappend
> @@ -2,6 +2,7 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>   
>   IMX_PATCHES = " file://gstplaybin-remove-flag-deinterlace.patch \
>                   file://0001-basetextoverlay-make-memory-copy-when-video-buffer-s.patch \
> +                file://0002-gstplaysink-don-t-set-async-of-custom-text-sink-to-f.patch \
>   "
>   SRC_URI_append_mx6 = "${IMX_PATCHES}"
>   SRC_URI_append_mx7 = "${IMX_PATCHES}"



More information about the meta-freescale mailing list