[meta-freescale] [PATCH] firmware-imx: Add firmware for WiFi and Bluetooth

[Otavio Salvador]

On Wed, Aug 10, 2016 at 5:18 PM, Daiane Angolini
<daiane.angolini at nxp.com> wrote:
> Add firmware for BCM4339/TypeZP and include a new sub-package firmware-imx-bcm4339
>
> Signed-off-by: Daiane Angolini <daiane.angolini at nxp.com>

The patch looks good; the only remark is about the /lib use. Please see below.

> ---
>  recipes-bsp/firmware-imx/firmware-imx.inc    | 11 +++++++++--
>  recipes-bsp/firmware-imx/firmware-imx_5.4.bb |  4 ++++
>  2 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-bsp/firmware-imx/firmware-imx.inc b/recipes-bsp/firmware-imx/firmware-imx.inc
> index 558f7fb..290a241 100644
> --- a/recipes-bsp/firmware-imx/firmware-imx.inc
> +++ b/recipes-bsp/firmware-imx/firmware-imx.inc
> @@ -6,13 +6,17 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8cf95184c220e247b9917e7244124c5a"
>
>  PE = "1"
>
> -SRC_URI = "${FSL_MIRROR}/firmware-imx-${PV}.bin;fsl-eula=true"
> +SRC_URI = "${FSL_MIRROR}/firmware-imx-${PV}.bin;fsl-eula=true \
> +           git://git.freescale.com/imx/imx-firmware.git;branch=${SRCBRANCH};destsuffix=${S}/git"
>
>  inherit fsl-eula-unpack
>
>  do_install() {
>      install -d ${D}/lib/firmware/imx
> +    install -d ${D}/lib/firmware/bcm
>      cp -rfv firmware/* ${D}/lib/firmware/
> +    cp -rfv git/BCM4339/TypeZP/BCM4339_wifi/*.bin ${D}/lib/firmware/bcm
> +    cp -rfv git/BCM4339/TypeZP/BCM4339_BT/*.hcd ${D}/lib/firmware/

Please before adding those, do you mind to rework the recipe and avoid
using /lib explicitly? We ought to use ${base_libdir} instead.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750